Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin names have different formats #2544

Closed
skoeva opened this issue Nov 7, 2024 · 0 comments · Fixed by #2572
Closed

Plugin names have different formats #2544

skoeva opened this issue Nov 7, 2024 · 0 comments · Fixed by #2572
Assignees
@skoeva
Labels
bug Something isn't working plugins

Comments

@skoeva
Copy link
Contributor

skoeva commented Nov 7, 2024

Describe the bug

The plugin names have different formats as shown below
One has the @headlamp-k8s and the others don't

To Reproduce

Steps to reproduce the bug:

  1. Open Headlamp and go to the plugins settings
  2. See the different name formats:

image

Are you able to fix this issue?

Yes, and a suggestion for a fix is described here if anyone else is interested in working on this:

maybe a good practice for the plugin name would be to split the org off and use it for the Origin of the plugin if no other alternative is provided; and regardless, always add the reminder of that split as the name.
So @headlamp-k8s/flux would become just flux as the name, and the origin should say headlamp-k8s, unless an author is set (this last part is already set in the logic)
@skoeva skoeva added bug Something isn't working plugins labels Nov 7, 2024
@skoeva skoeva self-assigned this Nov 14, 2024
skoeva added a commit that referenced this issue Nov 14, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
9e7c439 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Nov 14, 2024 that will close this issue
frontend: PluginSettings: Use author for plugin origin #2572
Merged
2 tasks
@skoeva skoeva mentioned this issue Nov 14, 2024
Merged
2 tasks
skoeva added a commit that referenced this issue Nov 14, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
761dfb8 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 14, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
95d150f 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 14, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
4072cb9 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 15, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
75329d5 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 15, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
60f5e82 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 15, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
f6598ee 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 19, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
35ba0fc 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 21, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
0bf951b 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva added a commit that referenced this issue Nov 21, 2024
@skoeva
frontend: PluginSettings: Use author for plugin origin
39ac3ee 
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <[email protected]>
@github-project-automation github-project-automation bot moved this from Queued to Done in Release Plan / Roadmap Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
bug Something isn't working plugins
Projects
Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: PluginSettings: Use author for plugin origin headlamp-k8s/headlamp
1 participant
@skoeva