plugin-catalog: Rework installed list to include all plugins #117
Conversation
vyncent-t
force-pushed
the
plugin-install-list-rework
branch
from
766ca37
to
89374b5
Compare
Signed-off-by: Vincent T <[email protected]>
vyncent-t
force-pushed
the
plugin-install-list-rework
branch
from
89374b5
to
774d8ce
Compare
| }} | ||
| > | ||
| <Typography variant="h6" components="h2"> | ||
| Installed from the Plugin Catalog |
There was a problem hiding this comment.
The title of the section is already "Installed". So here we could just have Plugins from the Catalog.
| }} | ||
| > | ||
| <Typography variant="h6" components="h2"> | ||
| Other Installed Plugins |
There was a problem hiding this comment.
And here we could use Other Plugins
| getter: otherInstalledPlugins => ( | ||
| <Box> | ||
| <Link | ||
| routeName={`pluginDetails`} |
There was a problem hiding this comment.
This lliteral is not replacing any var, so it may be "pluginDetails" instead (no {} needed either).
| @@ -81,8 +152,25 @@ export function PluginInstalledList() { | |||
| } | |||
| } | |||
|
|
|||
| function fetchOtherInstalledPlugins() { | |||
| const storedPlugins = localStorage.getItem('headlampPluginSettings'); | |||
There was a problem hiding this comment.
Is this the correct way to get the plugins? I think there's currently an issue related to this, since it mentions plugins settings but we have the package.json stored there, although it's likely a bug.
See #this comment.
| <Box> | ||
| <Link | ||
| routeName={`pluginDetails`} | ||
| params={{ name: otherInstalledPlugins.name }} |
There was a problem hiding this comment.
We should (in a different commit) make sure that the names of plugins are separated into org+name. We can use the org as the author. See:
headlamp-k8s/headlamp#2572
Description
Solves Issue: #2586
This PR addresses the issue observed during our ContribuFest at KubeCon, where users expressed confusion about the
Installedview in the Plugin Catalog. Specifically, users were expecting to find their development plugins in theInstalledview, but only plugins installed via the Plugin Catalog were listed.To resolve this, this PR proposes the following updates:
Installedview in the Plugin Catalog will now display all installed plugins, regardless of their installation source.Installed from the Plugin Catalog.Other Installed Plugins.These changes aim to improve user experience by consolidating plugin information in one view while maintaining clarity about their source and functionality.
Image
Changes Made
Installedview to:Installed from the Plugin CatalogandOther Installed Plugins.Steps to Test
Installedview and confirm:Installed from the Plugin CatalogorOther Plugins.Notes
Other Pluginswill not include uninstall functionality if they were not installed via the Plugin Catalog.