frontend: SectionHeader: Fix prop alignment #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
sniok
reviewed
Nov 27, 2024
This change addresses a regression introduced by #2572 since the SectionHeader components were aligned in a column, causing title side actions to appear under the title. Now, subtitles should appear under the title, and title side actions should appear next to the title. Fixes: #2605 Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva
force-pushed
the
sectionheader-fix
branch
from
91a65d0 to
f0bd9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a regression introduced by #2572 since the SectionHeader components were aligned in a column, causing title side actions to appear under the title. Now, subtitles should appear under the title, and title side actions should appear next to the title.
Fixes: #2605
Testing
Subtitles
@org-name/plugin-name(i.e.@kinvolk/dynamic-clustersTitle side actions