Stream sync protocol #3535
Closed
Stream sync protocol #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackyWYX
force-pushed
the
stream_downloader
branch
4 times, most recently
from
b9f4800
to
17c94ae
Compare
rlan35
reviewed
Feb 19, 2021
rlan35
reviewed
Feb 19, 2021
rlan35
reviewed
Feb 19, 2021
|
Are we ready to test this on a real network? |
Yep, ready! :) @LeoHChen |
JackyWYX
force-pushed
the
stream_downloader
branch
2 times, most recently
from
92498ad
to
e06dad8
Compare
JackyWYX
force-pushed
the
stream_downloader
branch
from
8ff2484
to
edc8884
Compare
…rvice. 1. Added some functionality to HostV2 for stream support. 2. Added new module discovery under p2p host to replace the networkInfo service. 3. Make dht datastore badger only active on bootstrap nodes. For normal nodes, badger is disabled by default. It can also be enabled by flags.
…ded metadata rpc.
JackyWYX
force-pushed
the
stream_downloader
branch
from
6dd0f99
to
cd596aa
Compare
LeoHChen
reviewed
Feb 26, 2021
| @@ -7,7 +7,7 @@ import ( | |||
| "strings" | |||
| "testing" | |||
|
|
|||
| "github.com/harmony-one/harmony/api/service/syncing/downloader" | |||
| "github.com/harmony-one/harmony/api/service/legacysync/downloader" | |||
There was a problem hiding this comment.
the rename of the package from syncing to legacysync should be a separate PR to simplify this PR.
| @@ -1269,3 +1282,97 @@ func applyPrometheusFlags(cmd *cobra.Command, config *harmonyConfig) { | |||
| config.Prometheus.EnablePush = cli.GetBoolFlagValue(cmd, prometheusEnablePushFlag) | |||
| } | |||
| } | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
the new flag added can also go to a new PR, can easily be merged.
|
|
||
| if consensus.dHelper != nil { | ||
| consensus.dHelper.start() | ||
| } |
There was a problem hiding this comment.
any error message if dHelper == nil?
| return nil | ||
| } | ||
|
|
||
| func (consensus *Consensus) waitForCommit() { |
There was a problem hiding this comment.
add a comment to this function please.
This was referenced Feb 26, 2021
This was referenced Mar 12, 2021
Merged
|
Since most of the code in this branch is already done in #3588, closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important notice
Since the size of this PR is too large for review, will split this PR to a set of small PRs for review. The breakdown PR will follow a bottom-up sequence for review.
Description
Tests
Current known issues
failed to negotiate security protocol: error reading handshake message: noise: message is too short(Peers Cannot Successfully Handshake libp2p/go-libp2p-noise#70) This issue is already fixed in libp2p version v0.13.0. Will upgrade libp2p after this release (frozen code).