Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stream] added sync stream protobuf message module #3561

Merged
merged 2 commits into from
Mar 3, 2021
Merged

[stream] added sync stream protobuf message module #3561

merged 2 commits into from
Mar 3, 2021

Conversation

JackyWYX
Copy link
Contributor

@JackyWYX JackyWYX commented Mar 1, 2021

Description

This is a break down PR of #3535.

Added protobuf message protocol for sync stream protocol.

@JackyWYX JackyWYX requested review from rlan35 and LeoHChen March 1, 2021 10:27
@JackyWYX JackyWYX self-assigned this Mar 1, 2021
@JackyWYX JackyWYX mentioned this pull request Mar 1, 2021
Closed
LeoHChen
LeoHChen approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to add metrics to keep track of the request later.

@rlan35 rlan35 merged commit 3dcc92c into harmony-one:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoHChen LeoHChen LeoHChen approved these changes

@rlan35 rlan35 rlan35 approved these changes

Assignees

@JackyWYX JackyWYX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackyWYX @rlan35 @LeoHChen