[Stream] added stream downloader to consensus #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlan35
reviewed
Mar 15, 2021
rlan35
reviewed
Mar 15, 2021
| consensus.dHelper.d.DownloadAsync() | ||
| consensus.current.SetMode(Syncing) | ||
| for _, v := range consensus.consensusTimeout { | ||
| v.Stop() |
There was a problem hiding this comment.
will the timer be reset when the sync is finished?
There was a problem hiding this comment.
The timer is restarted in consensus.Start()
// consensus/consensus_v2.go:346
case <-consensus.syncReadyChan:
...
consensus.consensusTimeout[timeoutConsensus].Start()
I currently did not refactor this part of code because:
- Both legacy sync and stream sync touches this part logic.
- I want to minimize the interface change related to existing consensus logic when adding new feature.
Probably this piece of code can be better refactored when DNS sync is fully removed. Added TODO. Thanks for bring this up.
JackyWYX
force-pushed
the
stream_consensus
branch
from
3fc391d
to
72286f0
Compare
rlan35
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a break down of #3535, and is on top of #3587.
Added stream downloader to consensus. Now consensus will trigger new downloader logic only if downloader is setup.