[stream] added stream manager module #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JackyWYX
force-pushed
the
streammanager
branch
from
bb5dc2e
to
f5224d6
Compare
rlan35
reviewed
Mar 1, 2021
| const ( | ||
| // checkInterval is the default interval for checking stream number. If the stream | ||
| // number is smaller than softLoCap, an active discover through DHT will be triggered. | ||
| checkInterval = 30 * time.Second |
There was a problem hiding this comment.
how are these numbers chosen?
There was a problem hiding this comment.
By estimation without solid evidence. Basically this is just like estimating the timeout to do a HTTP request. The only trick here is to make discTimeout less than checkInterval to avoid simultaneous host/client stream setup. Do you have other references that these numbers can be analyzed upon?
There was a problem hiding this comment.
We can probably observe the timeout by adding prometheus metrics and change to a more solid value after launch. For now I think the number is good to start with. Do you other references that can be helped to determine these number's values?
rlan35
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breakdown PR of #3535 and is on top of #3552.
Stream manager do the following job: