release: v10.1.0 #7371
Merged
release: v10.1.0 #7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Merge master back into develop following v10.0.0 release
* fix: set flyout visbility on calling setExpanded * move setVisible to only set false when category is no longer expanded
…#7249) * fix: Restore HSV_SATURATION and HSV_VALUE accessors Contrary to the notice at the top of the `Object.defineProperties` call, these were not actually marked as deprecated, and their removal in Blockly 10.0.0 constituted an avoidable zero-notice breaking change. * deprecate: Add deprecation notices for HSV_SATURATION and HSV_VALUE DEPRECATION: Blockly.HSV_SATURATION and Blockly.HSV_VALUE are deprecated and will be removed in a future version of Blockly. Use Blockly.colour.getHsvSaturation / Blockly.colour.setHsvSaturation and Blockly.colour.getHsvValue / Blockly.colour.setHsvValue instead.
#7254) * feat(test): add helper functions for getting selected block and block by ID * chore: format test files * chore: fix lint
* chore: add test helpers for getting blocks from the toolbox * chore: format * chore: switch to use getBlockType * chore: format * chore: restore teardown
* chore: get procedure test passing on linux * chore: cleanup * chore: format
* fix(tests): Fix invalid import paths in mocha tests This resolves the warnings generated during buildDeps by closure-make-deps. This commit does not attempt to address #7224 or otherwise rationalise the imports and usage thereof. * fix(tests): Fix failing context menu item test Test appears to have been wrong: Block.prototype.getIcon is typed as getIcon<T extends IIcon>(/* ... */): T | undefined and documented as "@returns The icon with the given type if it exists on the block, undefined otherwise." * refactor(tests): Clean up inconsistent usage of CommentIcon Tweak the test files touched by PR #7200 to be consistent with existing usage of Blockly.icons.CommentIcon instead of importing this separately.
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Merge pull request #7271 from google/master
* fix: disposing workspace comments. * whitespace formatting
* feat(tests): add test for collapsing block * chore: format * chore: format * feat(tests): add right-click tests and helpers * chore(tests): respond to review feedback
* chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field * chore: create test for undo block movements and editing a field
* chore(test): release strictness of jsdoc parsing in browser tests * chore(tests): add jsdoc to browser test helper functions * Update tests/browser/test/test_setup.js Co-authored-by: Beka Westberg <[email protected]> --------- Co-authored-by: Beka Westberg <[email protected]>
* chore: Added test for loading json and interblock deletion * chore: Added test for loading json and interblock deletion * chore: Added test for loading json and interblock deletion * chore: Added test for loading json and interblock deletion * chore: Added test for loading json and interblock deletion
* chore(tests): Add tests for adding and removing comments * chore(tests): respond to PR feedback
* fix: add compose and decompose errors to mutator icon * chore: format
* refactor(tests): Have testSetup accept a URL Have testSetup accept a URL. Make testFileLocations a dictionary whose values are URLs, and change the spellings of the keys to be CONSTANT_CASE. This allows tests to specify their own URL, or to add a query or fragment. * feat(tests): Add getAllBlocks helper * test: Verify drag blocks works properly * chore(tests): Reformat comments Manually reformat comments to comply with styleguide.
…t compatibility (#7295) * fix(generators): Add missing declarations for Order enums * chore(generators): Remove spurious whitespace * fix(generators): Make provideFunction_ etc. public Remove the protected declaration on provideFunction_ and FUNCTION_NAME_PLACEHOLDER_ so they can be used from generator functions written in TypeScript. Not strictly part of #7283, but closely related and required to fixing the related issue google/blockly-samples#1785. * chore(generators): format
* fix: Correct errors in HSV_SATURATION, HSV_VALUE accessors Fix the comment / message errors noted in #7249 (comment) * chore: Add renamings for HSV_SATURATION, HSV_VALUE
* chore: add tests for disabling blocks * chore: update asserts to be one line * fix: test setup
* fix(generators): Changes to exports and access controls for TypeScript compatibility (#7295) * fix(generators): Add missing declarations for Order enums * chore(generators): Remove spurious whitespace * fix(generators): Make provideFunction_ etc. public Remove the protected declaration on provideFunction_ and FUNCTION_NAME_PLACEHOLDER_ so they can be used from generator functions written in TypeScript. Not strictly part of #7283, but closely related and required to fixing the related issue google/blockly-samples#1785. * chore(generators): format (cherry picked from commit d503fbb) * fix: Correct errors in `HSV_SATURATION`, `HSV_VALUE` accessors (#7297) * fix: Correct errors in HSV_SATURATION, HSV_VALUE accessors Fix the comment / message errors noted in #7249 (comment) * chore: Add renamings for HSV_SATURATION, HSV_VALUE (cherry picked from commit 1bc4f67) * release: Update version number to 10.0.2 --------- Co-authored-by: Christopher Allen <[email protected]>
fix: Add delay after block connection. Otherwise it can randomly and silently fail.
* fix(blocks): boolean variable block wrong shape for zelos * fixup! fix(blocks): boolean variable block wrong shape for zelos
* fix: update build path for windows When using single quote on windows, e.g. 'build/src', the folder are created with a single quote at the beginning `'build` and end `src'`. This commit fixes this issue. * fix: update python command and folder separator Ensure that when running on windows, python command is python and not python3. Also, separators are normalized to posix style `/` even on windows system * fix: add global PYTHON constant to run python command * fix: simplify `path.sep` to forwadslash since it is cross-platform * fix(syntax): replace double quote with single quote
* fix(tests): context menu delete test * fix(tests): try increasing pause length after keys
* chore(tests): use helpers for the basic drag test in the playground * chore(tests): miscellaneous test cleanup * chore: format * feat(tests): add test that drags out every block from the toolbox * feat(tests): add RTL version of toolbox drag tests * chore: lint * chore(tests): respond to PR feedback
* fix: removed X & Y from toolbox.ts and replaced movBy to moveTo in Horizontal/ Vertical flyout * forget to run npm lint and format * removed the mistakenly added comment
* chore: change the way we look for upstream remote * chore: use js instead of shell thanks christopher Co-authored-by: Christopher Allen <[email protected]> * chore: store the found upstream name --------- Co-authored-by: Christopher Allen <[email protected]>
Glockenspiel broke due to 'query' now being required within a client context. This change fixed Glockenspiel. Blockly samples doesn't appear to be broken yet, but Glokenspeil broke at midnight yesterday. Similar change being made to Blockly Games.
* chore: update loop style to remove any type * feat: make initView protected and initModel public * feat: make image element in image field protected
* fix: insertion markers to use JSON deserialization * removed the const DUPLICATE_BLOCK_ERROR * modified to import module instead of referencing * removed coments for better readability
* fix: connect animation * chore: format
ericblackmonGoogle
requested review from
NeilFraser and
BeksOmega
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -156,7 +156,7 @@ | |||
| // library we use, mainly for goog.require / goog.provide / | |||
| // goog.module). | |||
| document.write( | |||
| `<script src="${options.root}build/src/closure/goog/base.js"></script>` | |||
| `<script src="${options.root}build/src/closure/goog/base.js"></script>`, | |||
Check warning
Code scanning / CodeQL
Client-side cross-site scripting Medium test
|
Please put the title of the PR in conventional commit format: We might want to fix the formatting by adding another commit to the |
maribethb
approved these changes
Aug 10, 2023
|
Was able to fix the format through the Git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Proposed Changes
Merge release candidate v/10.1.0 into master