chore: update app engine version names #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: chore
BeksOmega
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes bad names for app engine versions
Proposed Changes
Behavior Before Change
names for app engine versions were based on minor-patch version numbers. This made sense when the minor number was a date, but doesn't make sense now that we're using true semver.
Behavior After Change
The version number for app engine is just the version number with all
.replaced with-e.g.10-0-0or9-3-4-beta-4Reason for Changes
We keep overwriting old versions on app engine. This makes it harder to go back and look at old versions of blockly. It's nice to be able to look back easily at any published version of blockly.
Test Coverage
Documentation
I'll update our team docs
Additional Information
I did not touch the format of the "beta" version of the command, because that is used for e.g. testing week and not real published betas of the package. So it makes more sense to use the date for that because it might be updated every day of testing week, or something, when we might not be publishing real beta versions of the package. This format will not overlap the format if we ever do publish the app engine site based on an actual beta of the package.