Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test helpers for getting blocks from the toolbox #7255

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Adds helper methods for getting blocks from the flyout.

@BeksOmega BeksOmega requested a review from a team as a code owner July 6, 2023 17:39
@BeksOmega BeksOmega requested a review from cpcallen July 6, 2023 17:39
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Jul 6, 2023
@rachel-fenichel rachel-fenichel self-requested a review July 6, 2023 18:02
@rachel-fenichel rachel-fenichel self-assigned this Jul 6, 2023
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back teardown, then lgtm.

@@ -112,6 +94,6 @@ suite('Testing Connecting Blocks', function (done) {

// Teardown entire suite after test are done running
suiteTeardown(async function () {
await browser.deleteSession();
// await browser.deleteSession();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@BeksOmega BeksOmega enabled auto-merge (squash) July 6, 2023 18:05
@BeksOmega BeksOmega merged commit 956b72a into google:develop Jul 6, 2023
@BeksOmega BeksOmega deleted the chore/test-helpers-flyout branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants