fix: removed X & Y from toolbox.ts and replaced movBy to moveTo

[varshneydevansh]

The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide
• I ran npm run format and npm run lint

The details

Resolves

• Fixes Built-in flyouts position blocks with x and y values incorrectly #6280

Proposed Changes

The BlockInfo type should be updated to not include X and Y.
Blockly has two kinds of flyouts built-in, horizontal and vertical. You should update the layout logic in both of them.
The flyouts should be changed to use moveTo instead of moveBy

Behavior Before Change

The BlockInfo type was picking up the values of x and y henceforth the position of the Toolbox Element was getting changed.

Behavior After Change

After removing the X and Y from the BlockInfo type the Toolbox Element is now ignoring the value and introducing the chnage to the code in files

• core/flyout_horizontal.ts
• core/flyout_vertical.ts

to use moveTo instead of moveBy

Ignoring the x and y properties on blocks would allow them to position correctly.

Reason for Changes

Because, the blocks were using the relative coordinates instead of the absolute coordinates

Test Coverage

Browser which I used is MS Edge Version 115.0.1901.188 (Official build) (64-bit)

Documentation

Additional Information

It's my first PR on this project, so I might make mistakes.

[varshneydevansh]

@BeksOmega can you help me with the changes which I made are correct or not?

[BeksOmega]

@BeksOmega can you help me with the changes which I made are correct or not?

Hello :D Currently the review for this is assigned to @maribethb ! I'll ask her if she wants me take it =)

[BeksOmega]

This LGTM =) Could you update the PR description to describe how you tested this? Once we have info about that and CI passes I'll merge this!

[varshneydevansh]

I will do this in the morning, tho. I did try doing the original steps earlier and found no changes. Furthermore, I will do it in the morning with a fresh perspective.

[varshneydevansh]

Hi @BeksOmega ,

I tested it now and the newly modified proposed changes are working as they were expected.

I am attaching the SS for both the modified code and the unchanged code with different value in playground.html and change getToolboxElement

• Modified code -

• Unchanged code -

[BeksOmega]

Sweet looks great! Thank you for the fix and the testing @varshneydevansh :D