fix!: make scroll options work without drag surfaces #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
a team and
cpcallen
and removed request for
a team
cpcallen
approved these changes
Jun 13, 2023
plugins/scroll-options/src/index.js
Outdated
| element = this.workspace_.svgGroup_; | ||
| } | ||
|
|
||
| // TODO: We should maybe add an accessor for the svgGroup_? |
There was a problem hiding this comment.
Please open a bug about this (maybe with an explanation more comprehensible to the casual observer) and reference it here. (Make the bug title along the lines of "consider whether to…" if you're not sure if we want to do this.)
There was a problem hiding this comment.
Done! google/blockly#7157
BeksOmega
force-pushed
the
fix/scroll-options
branch
from
471ef8a
to
88fb645
Compare
1 task
BeksOmega
force-pushed
the
fix/scroll-options
branch
from
9100976
to
9e93e9a
Compare
BeksOmega
force-pushed
the
fix/scroll-options
branch
from
9e93e9a
to
94d68c3
Compare
maribethb
added a commit
that referenced
this pull request
Jun 28, 2023
* chore: update all plugins and examples to [email protected] (#1722) * chore: update all plugins and examples to [email protected] * chore: update angular packagelock * chore: migrate textToDom rename * chore: fix modal * chore: fix keyboard nav test * chore: fix variable modal * chore: fix shareable procedure blocks * fix: procedure blocks build * fix more build stuff * fix: renaming build problems * chore: fix lint * chore: fix return annotations * chore: maybe actually fix lint * fix: update graph demo for blockly v10 (#1732) * chore: add color, angle, multiline fields to demo page (#1728) * fix!: make scroll options work without drag surfaces (#1666) * fix!: make scroll options work without drag surfaces * chore: PR comments * chore: unprivate backpack plugin (#1738) * fix: continuous flyout calling wrong private method (#1725) * fix: continuous flyout calling wrong private method * fix: use better API * fix: don't duplicate logic * chore: remove serializable demo (#1737) * fix: update demo fields for blockly v10 and remove closure modules (#1735) * fix: update devsite demo for blockly v10 (#1736) * fix: update all usages of generators in script tags for blockly v10 (#1734) * feat!: update all plugins to use blockly-v10.0.0 (#1744) --------- Co-authored-by: Beka Westberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1664
Tested against google/blockly#6758
Additional information
Not mergable until after v10 release.
TODO: Need to bump minimum version of Blockly & master version of plugin.