fix: update demo fields for blockly v10 and remove closure modules #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Jun 22, 2023
maribethb
added a commit
that referenced
this pull request
Jun 28, 2023
* chore: update all plugins and examples to [email protected] (#1722) * chore: update all plugins and examples to [email protected] * chore: update angular packagelock * chore: migrate textToDom rename * chore: fix modal * chore: fix keyboard nav test * chore: fix variable modal * chore: fix shareable procedure blocks * fix: procedure blocks build * fix more build stuff * fix: renaming build problems * chore: fix lint * chore: fix return annotations * chore: maybe actually fix lint * fix: update graph demo for blockly v10 (#1732) * chore: add color, angle, multiline fields to demo page (#1728) * fix!: make scroll options work without drag surfaces (#1666) * fix!: make scroll options work without drag surfaces * chore: PR comments * chore: unprivate backpack plugin (#1738) * fix: continuous flyout calling wrong private method (#1725) * fix: continuous flyout calling wrong private method * fix: use better API * fix: don't duplicate logic * chore: remove serializable demo (#1737) * fix: update demo fields for blockly v10 and remove closure modules (#1735) * fix: update devsite demo for blockly v10 (#1736) * fix: update all usages of generators in script tags for blockly v10 (#1734) * feat!: update all plugins to use blockly-v10.0.0 (#1744) --------- Co-authored-by: Beka Westberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pitch-field-demo, update
Blockly.WidgetDiv.DIVtoBlockly.WidgetDiv.getDiv()because the former was removed. This is the only required change to make the demo work with v10.However, the
goog.requireandgoog.providestatements really deeply confused me for a few minutes because I did not see where we were compiling these fields using Closure Compiler. It turns out, we're not, and these are defined as empty functions in theindex.htmlfor the demo. This is really confusing as a demo and does not help new developers figure out how we want them to use Blockly. Therefore I also took this opportunity to remove the references to Closure Compiler from the pitch field and turtle field demos.