fix: update all usages of generators in script tags for blockly v10 #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
reviewed
Jun 26, 2023
Comment on lines
+16
to
+27
| 'type': 'wait_seconds', | ||
| 'message0': ' wait %1 seconds', | ||
| 'args0': [{ | ||
| 'type': 'field_number', | ||
| 'name': 'SECONDS', | ||
| 'min': 0, | ||
| 'max': 600, | ||
| 'value': 1, | ||
| }], | ||
| "previousStatement": null, | ||
| "nextStatement": null, | ||
| "colour": "%{BKY_LOOPS_HUE}", | ||
| 'previousStatement': null, | ||
| 'nextStatement': null, | ||
| 'colour': '%{BKY_LOOPS_HUE}', |
There was a problem hiding this comment.
Unless this file gets passed through Closure Compiler in ADVANCED_OPTIMIZATIONS mode the quotes on the keys here are not required.
There was a problem hiding this comment.
We quote tons of stuff that doesn't need to be, all over the place :/ these were only updated to single quotes because i format my files on save
cpcallen
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
I think the wrong name is used in google/blockly#7169 and I'm following up with that.
Indeed the wrong name was used in that PR; thanks for catching that!
maribethb
added a commit
that referenced
this pull request
Jun 28, 2023
* chore: update all plugins and examples to [email protected] (#1722) * chore: update all plugins and examples to [email protected] * chore: update angular packagelock * chore: migrate textToDom rename * chore: fix modal * chore: fix keyboard nav test * chore: fix variable modal * chore: fix shareable procedure blocks * fix: procedure blocks build * fix more build stuff * fix: renaming build problems * chore: fix lint * chore: fix return annotations * chore: maybe actually fix lint * fix: update graph demo for blockly v10 (#1732) * chore: add color, angle, multiline fields to demo page (#1728) * fix!: make scroll options work without drag surfaces (#1666) * fix!: make scroll options work without drag surfaces * chore: PR comments * chore: unprivate backpack plugin (#1738) * fix: continuous flyout calling wrong private method (#1725) * fix: continuous flyout calling wrong private method * fix: use better API * fix: don't duplicate logic * chore: remove serializable demo (#1737) * fix: update demo fields for blockly v10 and remove closure modules (#1735) * fix: update devsite demo for blockly v10 (#1736) * fix: update all usages of generators in script tags for blockly v10 (#1734) * feat!: update all plugins to use blockly-v10.0.0 (#1744) --------- Co-authored-by: Beka Westberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the usage of generators in all examples and codelabs that load Blockly from script tags, except graph demo (done in #1732) and the devsite demo page (which does something slightly different involving dropdowns so I want to test separately).
Generally,
Blockly.JavaScript->javascript.javascriptGeneratorBlockly.JavaScript['block_name']->javascript.javascriptGenerator.forBlock['block_name']Blockly.JavaScript.ORDER_FOO->javascript.Order.FOOI tested each of the example pages, and loaded the codelabs complete code page (after locally updating to point to blockly@beta)
Also updated the README of the hsv-colour-sliders plugin which still used old style generator names with import statements, which definitely doesn't work anymore.
N.B. I don't think this change should have been strictly required, because Blockly.JavaScript is supposed to remain backwards-compatible but deprecated for Blockly v10. I think the wrong name is used in google/blockly#7169 and I'm following up with that.