Rename buffer to encoder in wgpu_command_buffer_copy_* functions #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also regenerates `wgpu.h` and updates uses of `wgpu_command_buffer_copy_buffer_to_buffer` in `compute/main.c`
|
This cbindgen error is not stopping it from working. It generates headers fine on my end. Could you double check? |
|
Yep, you are right, it emits the file. |
bors bot
added a commit
that referenced
this pull request
Aug 20, 2019
299: Rename buffer to encoder in wgpu_command_buffer_copy_* functions r=kvark a=yanchith
This also regenerates `wgpu.h` and updates uses of `wgpu_command_buffer_copy_buffer_to_buffer` in `compute/main.c`.
EDIT: all good...
~Note that I couldn't regenerate `wgpu-remote.h` because of the following cbindgen error:~
```
ERROR: Cannot find a mangling for generic path GenericPath { path: Path { name: "Adapter" }, export_name: "Adapter", generics: [Path(GenericPath { path: Path { name: "Backend" }, export_name: "Backend", generics: [], ctype: None })], ctype: None }. This usually means that a type referenced by this generic was incompatible or not found.
```
Should we investigate before merging? Maybe I am just using an unlucky nightly?
Closes: #250
Co-authored-by: yanchith <[email protected]>
Build succeeded |
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
300: Properly free pass contents r=kvark a=kvark Fixes gfx-rs#299 Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also regenerates
wgpu.hand updates uses ofwgpu_command_buffer_copy_buffer_to_bufferincompute/main.c.EDIT: all good...
Note that I couldn't regeneratewgpu-remote.hbecause of the following cbindgen error:Should we investigate before merging? Maybe I am just using an unlucky nightly?
Closes: #250