rename methods for command buffer to methods for command encoder #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porky11
force-pushed
the
buffer-encoder-method-rename
branch
2 times, most recently
from
c36698a to
231bfeb
Compare
grovesNL
approved these changes
Aug 10, 2019
ffi/wgpu-remote.h
Outdated
| @@ -1,72 +0,0 @@ | |||
|
|
|||
There was a problem hiding this comment.
Looks like this was accidentally removed, maybe it wasn't regenerated during make? If you can't get this to be generated, we could just amend the commit to keep it
There was a problem hiding this comment.
Yeah, something doesn't work correctly with ffi creation using make, not sure why. I'll fix it and force push it again
porky11
force-pushed
the
buffer-encoder-method-rename
branch
from
231bfeb to
8ae180a
Compare
porky11
force-pushed
the
buffer-encoder-method-rename
branch
from
8ae180a to
7df34c0
Compare
|
Should be fixed now |
kvark
approved these changes
Aug 12, 2019
|
ah, didn't realize we have a conflict |
Merge conflict |
|
@porky11 please rebase |
|
Replaced by #299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #250