Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGPUCommandBufferId vs. WGPUCommandEncoderId #250

Closed
DagAgren opened this issue Jul 17, 2019 · 3 comments · Fixed by #299
Closed

WGPUCommandBufferId vs. WGPUCommandEncoderId #250

DagAgren opened this issue Jul 17, 2019 · 3 comments · Fixed by #299
Labels
area: api Issues related to API surface good first issue Good for newcomers help required We need community help to make this happen.
Milestone
Version 0.3

Comments

@DagAgren
Copy link

Should this not be WGPUCommandEncoderId?

wgpu/ffi/wgpu.h

Line 647 in 32399cf

void wgpu_command_buffer_copy_buffer_to_buffer(WGPUCommandBufferId command_buffer_id,

@kvark
Copy link
Member

kvark commented Jul 18, 2019

You are correct, this should be the encoder ID. In our implementation today those are the same things, hence it works, but we should fix this code nevertheless.

@kvark kvark added good first issue Good for newcomers help required We need community help to make this happen. labels Jul 29, 2019
@Timo-DK
Copy link
Collaborator

Timo-DK commented Jul 29, 2019

Does this apply for all of the following methods:

wgpu/ffi/wgpu.h

Line 647 in 32399cf

void wgpu_command_buffer_copy_buffer_to_buffer(WGPUCommandBufferId command_buffer_id,

wgpu/ffi/wgpu.h

Line 654 in 32399cf

void wgpu_command_buffer_copy_buffer_to_texture(WGPUCommandBufferId command_buffer_id,

wgpu/ffi/wgpu.h

Line 659 in 32399cf

void wgpu_command_buffer_copy_texture_to_buffer(WGPUCommandBufferId command_buffer_id,

wgpu/ffi/wgpu.h

Line 664 in 32399cf

void wgpu_command_buffer_copy_texture_to_texture(WGPUCommandBufferId command_buffer_id,

Or just for the wgpu_command_buffer_copy_buffer_to_buffer?

@kvark
Copy link
Member

kvark commented Jul 29, 2019

Yes, it applies to all of these

@kvark kvark mentioned this issue Aug 7, 2019
Closed
@kvark kvark added the area: api Issues related to API surface label Aug 7, 2019
@porky11 porky11 mentioned this issue Aug 10, 2019
Closed
@kvark kvark added this to the Version 0.3 milestone Aug 17, 2019
@yanchith yanchith mentioned this issue Aug 20, 2019
Merged
@bors bors bot closed this as completed in 150d226 Aug 20, 2019
Patryk27 pushed a commit to Patryk27/wgpu that referenced this issue Nov 23, 2022
@JCapucho
msl-out: Use io::Write instead of fmt::Write (gfx-rs#250)
d45d11e 
* msl-out: Use io::Write instead of fmt::Write

* msl-out: merge std use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface good first issue Good for newcomers help required We need community help to make this happen.
Projects
None yet
Milestone
Version 0.3
3 participants
@kvark @Timo-DK @DagAgren