Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying functions should get CommandEncoderId instead of CommandBufferId #271

Closed
kvark opened this issue Aug 7, 2019 · 1 comment
Closed

Copying functions should get CommandEncoderId instead of CommandBufferId #271

kvark opened this issue Aug 7, 2019 · 1 comment
Labels
area: api Issues related to API surface

Comments

@kvark
Copy link
Member

kvark commented Aug 7, 2019 •
edited
Loading

They are technically the same on the implementation side, but we should fix the API to reflect the proper semantics. This affects: wgpu_command_buffer_copy_* routines - they should be renamed to wgpu_command_encoder_copy_* correspondingly.
@kvark kvark added the area: api Issues related to API surface label Aug 7, 2019
@kvark
Copy link
Member Author

kvark commented Aug 7, 2019

dupe of #250

@kvark kvark closed this as completed Aug 7, 2019
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @HalfVoxel
[rs] Merge gfx-rs#271
e0ec201 
271: Improve docs for BindingType r=kvark a=HalfVoxel

I think everything should be correct.

The readonly flags seem obvious at face value, but I couldn't find anything in the specifications about them (other than some unrelated validation), so I didn't add any documentation for those fields.

Co-authored-by: Aron Granberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark