Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to diable validation layers at runtime #300

Closed
LaylBongers opened this issue Aug 20, 2019 · 3 comments
Closed

Option to diable validation layers at runtime #300

LaylBongers opened this issue Aug 20, 2019 · 3 comments
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request

Comments

@LaylBongers
Copy link
Contributor

Most of the time, because of the big performance hit Vulkan validation layers cause, I want to run my game without validation layers enabled even in debug mode.
Sometimes however, to debug a rendering issue, I'll want to enable them, preferably through a command line flag on my game.
It would be nice if, for example, Instance::new() had the option to disable or enable validation layers for the platform it's running on, besides just leaving it to the default value.

@kvark
Copy link
Member

kvark commented Aug 20, 2019

There are many ways to communicate that, and having this configurable would be an improvement.
Changing Instance::new is not preferred though, since it's nice to have all Instance types agree on how they are initialized.

@kvark kvark added the type: enhancement New feature or request label Aug 20, 2019
@kvark
Copy link
Member

kvark commented Aug 20, 2019

wwwwaaaaiiitttt, this is not gfx-rs repository, sorry. There is only one Instance type.
Before this can go anywhere, gfx-rs needs to have this configurable.

kvark added a commit to kvark/wgpu that referenced this issue Jun 3, 2021
300: Properly free pass contents r=kvark a=kvark

Fixes gfx-rs#299

Co-authored-by: Dzmitry Malyshau <[email protected]>
@cwfitzgerald cwfitzgerald added help required We need community help to make this happen. area: api Issues related to API surface labels Jun 5, 2022
@cwfitzgerald
Copy link
Member

Solved by #4230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants