6 -> main #480
Merged
6 -> main #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix ray query dist calc Signed-off-by: Ian Chen <[email protected]> * disable test Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Silvio <[email protected]>
* Added macos instructions Signed-off-by: Alejandro Hernández <[email protected]> * Fix Signed-off-by: Alejandro Hernández <[email protected]> Co-authored-by: Ian Chen <[email protected]>
…451) Fixes #439 Signed-off-by: Matias N. Goldberg <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Silvio <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: GitHub <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
…_buffer_range is not available (#462) - The definition of bufferFetch1 was failing for OpenGL < 4.2 resulting in compile errors for lighting shaders Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
* Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
- Fix a bug where the warning of an invalid anti-aliasing level in Ogre2RenderTarget was not being output - Set the FSAA level to 0 if the target level is invalid - Provide a list of valid options in the warning Signed-off-by: Rhys Mainwaring <[email protected]>
* Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <[email protected]>
* Fix ray query distance calculation (#438) * fix ray query dist calc Signed-off-by: Ian Chen <[email protected]> * disable test Signed-off-by: Ian Chen <[email protected]> * ogre: Add missing required Paging component (#452) Signed-off-by: Silvio <[email protected]> * Fix selection buffer material script (#456) Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]>
Signed-off-by: Hill Ma <[email protected]>
Fix lidar near plane clipping
* ogre: Do not assume that ogre plugins have lib prefix on macOS (#454) Signed-off-by: Silvio <[email protected]> * Fix compilation against Ogre 1.10.12 (#390) Signed-off-by: GitHub <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> * Avoid symbol redefition to fix armel builds (#457) * Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <[email protected]> * Fix logic on warning for ogre versions different than 1.9.x (#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <[email protected]> * Fix context attributes of glXCreateContextAttribsARB. (#460) Signed-off-by: Hill Ma <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Hill Ma <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 53.49% 53.52% +0.03%
==========================================
Files 192 194 +2
Lines 19566 19655 +89
==========================================
+ Hits 10466 10520 +54
- Misses 9100 9135 +35
Continue to review full report at Codecov.
|
ahcorde
requested changes
Oct 29, 2021
|
that test is failing on |
|
* update scaling ratio Signed-off-by: Ian Chen <[email protected]> * update center click Signed-off-by: Ian Chen <[email protected]> * revert change Signed-off-by: Ian Chen <[email protected]> * sytle Signed-off-by: Ian Chen <[email protected]>
|
it always seems to be failing on forward ports. I haven't figured out the correct solution to it yet. I've manually set DCO to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-rendering6 to main
Branch comparison: main...ign-rendering6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)