Fix ray query distance calculation #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #438 +/- ##
==================================================
+ Coverage 53.99% 55.83% +1.83%
==================================================
Files 147 147
Lines 14119 14120 +1
==================================================
+ Hits 7624 7884 +260
+ Misses 6495 6236 -259
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Sep 28, 2021
chapulina
added a commit
that referenced
this pull request
Oct 18, 2021
* Fix ray query distance calculation (#438) * fix ray query dist calc Signed-off-by: Ian Chen <[email protected]> * disable test Signed-off-by: Ian Chen <[email protected]> * ogre: Add missing required Paging component (#452) Signed-off-by: Silvio <[email protected]> * Fix selection buffer material script (#456) Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]>
srmainwaring
pushed a commit
to srmainwaring/gz-rendering
that referenced
this pull request
Oct 21, 2021
* fix ray query dist calc Signed-off-by: Ian Chen <[email protected]> * disable test Signed-off-by: Ian Chen <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
bug was introduced in #383 when the ray query code was converted to use selection buffer.
The distance result given was from the world origin to the intersection point. This PR fixes it so that it's from the camera to the intersection point.
The bug was not caught by the test as it was not testing ray queries using the selection buffer. This PR also turns it on in
UNIT_Utils_TESTand fixes a few tol checks.UNIT_Utils_TESTso disabled test in e13c1cdChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge