Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 -> 6 #476

Merged
merged 12 commits into from
Oct 19, 2021
Merged

5 -> 6 #476

merged 12 commits into from
Oct 19, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 19, 2021

➡️ Forward port

Port ign-rendering5 to ign-rendering6

Branch comparison: ign-rendering6...ign-rendering5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #476 (5a5f4cd) into ign-rendering6 (7c1430d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #476   +/-   ##
===============================================
  Coverage           53.57%   53.58%           
===============================================
  Files                 194      194           
  Lines               19635    19634    -1     
===============================================
  Hits                10520    10520           
+ Misses               9115     9114    -1     
Impacted Files Coverage Δ
include/ignition/rendering/Storage.hh 25.00% <ø> (ø)
ogre/src/OgreGaussianNoisePass.cc 1.81% <ø> (ø)
ogre/src/OgreGpuRays.cc 0.00% <ø> (ø)
ogre/src/OgreMaterial.cc 40.92% <ø> (ø)
ogre/src/OgreMaterialSwitcher.cc 0.00% <ø> (ø)
ogre/src/OgreRTShaderSystem.cc 43.12% <ø> (ø)
ogre/src/OgreScene.cc 26.57% <ø> (ø)
ogre/src/OgreText.cc 0.00% <ø> (ø)
ogre/src/OgreThermalCamera.cc 0.00% <ø> (ø)
ogre2/src/Ogre2RenderEngine.cc 79.95% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1430d...5a5f4cd. Read the comment docs.

@iche033 iche033 merged commit a0d71f6 into ign-rendering6 Oct 19, 2021
@iche033 iche033 deleted the merge_5_6_20211018 branch October 19, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants