Don't expect application/json type nodes to be files
#8544
Conversation
| @@ -10,6 +10,8 @@ async function onCreateNode({ node, actions, loadNodeContent, createNodeId }, pl | |||
| return pluginOptions.typeName | |||
| } else if (isArray) { | |||
| return _.upperFirst(_.camelCase(`${node.name} Json`)) | |||
| } else if (node.internal.type !== `File`) { | |||
| return `${node.internal.type} Json` | |||
There was a problem hiding this comment.
i am not sure if this is the better option, as this dictates the graphql schema, e.g. the contentful sets internal.type to _.camelCase(`${node.internal.type} ${key} JSONNode`) so you would need to query by that name. do you have examples from contentful? what about node.name?
There was a problem hiding this comment.
Is node.name always available and suitable for GraphQL? I have no dog in the fight, just trying to get the incompatibility resolved so I can keep moving on a project.
There was a problem hiding this comment.
well the type gets transformed to a valid graphql name, so when node.dir is "letter" node.internal.type is "Letter Json" and you can query letterJson (and allLetterJson).node.name is already used so i guess it's safe to use in this if branch as well. that said maybe we should let @pieh chime in.
There was a problem hiding this comment.
node.name is also File specific - but at least it won't crash if name is not set, but yeah, let's move this else if before else if (isArray)
|
cc @pieh |
…former - even if it would mostly be used for that
|
@pieh Thanks for the assistance, and for tests! |
* 'master' of github.com:gatsbyjs/gatsby: feat(cache-dir): Add a button for custom 404s in development (gatsbyjs#8548) fix: add ecosystem team for starters YAML fix: fix displaying and hydrating 404 page in production builds (gatsbyjs#8510) fix: don't expect `application/json` type nodes to be files (gatsbyjs#8544) Delete cds-takeaways.md (gatsbyjs#8552) chore(release): Publish chore: remove npm-run-all dep and update deps in e2e tests (gatsbyjs#8529) [www] Site/Starter Showcase refactor, rinse II (gatsbyjs#8411) Rfc process doc (gatsbyjs#8537) [www] a11y improvements (gatsbyjs#8536) Update the GraphQL stitching blog post & docs (gatsbyjs#8516) fix: change teams to reduce noise for people
gatsby-source-contentfulcreates nodes with a JSON type so we can't expect all nodes to have anode.dirproperty to generate a GraphQL type from.Fixes #8538.