fix: don't expect application/json type nodes to be files (#8544)

gatsbyjs · Sep 26, 2018 · cd780aa · cd780aa
1 parent b52c51f
commit cd780aa
Show file tree

Hide file tree

Showing 4 changed files with 290 additions and 104 deletions.
diff --git a/packages/gatsby-transformer-json/README.md b/packages/gatsby-transformer-json/README.md
@@ -7,7 +7,7 @@ arrays of objects and single objects.
 
 `npm install --save gatsby-transformer-json`
 
-You also need to have `gatsby-source-filesystem` installed and configured so it
+If you want to transform json files, you also need to have `gatsby-source-filesystem` installed and configured so it
 points to your files.
 
 ## How to use
@@ -182,15 +182,15 @@ or a function that receives the following arguments:
 [
   {
     "level": "info",
-    "message": "hurray",
+    "message": "hurray"
   },
   {
     "level": "info",
-    "message": "it works",
+    "message": "it works"
   },
   {
     "level": "warning",
-    "message": "look out",
+    "message": "look out"
   }
 ]
 ```
@@ -201,7 +201,7 @@ module.exports = {
     {
       resolve: `gatsby-transformer-json`,
       options: {
-        typeName: (({ node, object, isArray }) => object.level),
+        typeName: ({ node, object, isArray }) => object.level,
       },
     },
   ],

diff --git a/packages/gatsby-transformer-json/src/__tests__/__snapshots__/gatsby-node.js.snap b/packages/gatsby-transformer-json/src/__tests__/__snapshots__/gatsby-node.js.snap
@@ -41,7 +41,7 @@ Array [
         "internal": Object {
           "contentDigest": "whatever",
           "mediaType": "application/json",
-          "name": "test",
+          "type": "File",
         },
         "name": "nodeName",
         "parent": "SOURCE",
@@ -51,6 +51,55 @@ Array [
 ]
 `;
 
+exports[`Process JSON nodes correctly correctly creates a node from JSON which is a single object and doesn't come from fs 1`] = `
+Array [
+  Array [
+    Object {
+      "blue": true,
+      "children": Array [],
+      "funny": "yup",
+      "id": "foo",
+      "internal": Object {
+        "contentDigest": "8838e569ae02d98806532310fb2a577a",
+        "type": "NotFileJson",
+      },
+      "parent": "whatever",
+    },
+  ],
+]
+`;
+
+exports[`Process JSON nodes correctly correctly creates a node from JSON which is a single object and doesn't come from fs 2`] = `
+Array [
+  Array [
+    Object {
+      "child": Object {
+        "blue": true,
+        "children": Array [],
+        "funny": "yup",
+        "id": "foo",
+        "internal": Object {
+          "contentDigest": "8838e569ae02d98806532310fb2a577a",
+          "type": "NotFileJson",
+        },
+        "parent": "whatever",
+      },
+      "parent": Object {
+        "children": Array [],
+        "content": "{\\"id\\":\\"foo\\",\\"blue\\":true,\\"funny\\":\\"yup\\"}",
+        "id": "whatever",
+        "internal": Object {
+          "contentDigest": "whatever",
+          "mediaType": "application/json",
+          "type": "NotFile",
+        },
+        "parent": "SOURCE",
+      },
+    },
+  ],
+]
+`;
+
 exports[`Process JSON nodes correctly correctly creates nodes from JSON which is an array of objects 1`] = `
 Array [
   Array [
@@ -100,11 +149,12 @@ Array [
       "parent": Object {
         "children": Array [],
         "content": "[{\\"id\\":\\"foo\\",\\"blue\\":true,\\"funny\\":\\"yup\\"},{\\"blue\\":false,\\"funny\\":\\"nope\\"}]",
+        "dir": "/tmp/foo/",
         "id": "whatever",
         "internal": Object {
           "contentDigest": "whatever",
           "mediaType": "application/json",
-          "name": "test",
+          "type": "File",
         },
         "name": "nodeName",
         "parent": "SOURCE",
@@ -127,11 +177,12 @@ Array [
       "parent": Object {
         "children": Array [],
         "content": "[{\\"id\\":\\"foo\\",\\"blue\\":true,\\"funny\\":\\"yup\\"},{\\"blue\\":false,\\"funny\\":\\"nope\\"}]",
+        "dir": "/tmp/foo/",
         "id": "whatever",
         "internal": Object {
           "contentDigest": "whatever",
           "mediaType": "application/json",
-          "name": "test",
+          "type": "File",
         },
         "name": "nodeName",
         "parent": "SOURCE",
@@ -140,3 +191,91 @@ Array [
   ],
 ]
 `;
+
+exports[`Process JSON nodes correctly correctly creates nodes from JSON which is an array of objects and doesn't come from fs 1`] = `
+Array [
+  Array [
+    Object {
+      "blue": true,
+      "children": Array [],
+      "funny": "yup",
+      "id": "foo",
+      "internal": Object {
+        "contentDigest": "8838e569ae02d98806532310fb2a577a",
+        "type": "NotFileJson",
+      },
+      "parent": "whatever",
+    },
+  ],
+  Array [
+    Object {
+      "blue": false,
+      "children": Array [],
+      "funny": "nope",
+      "id": "uuid-from-gatsby",
+      "internal": Object {
+        "contentDigest": "f624311d932d73dcd416d2a8bea2b67d",
+        "type": "NotFileJson",
+      },
+      "parent": "whatever",
+    },
+  ],
+]
+`;
+
+exports[`Process JSON nodes correctly correctly creates nodes from JSON which is an array of objects and doesn't come from fs 2`] = `
+Array [
+  Array [
+    Object {
+      "child": Object {
+        "blue": true,
+        "children": Array [],
+        "funny": "yup",
+        "id": "foo",
+        "internal": Object {
+          "contentDigest": "8838e569ae02d98806532310fb2a577a",
+          "type": "NotFileJson",
+        },
+        "parent": "whatever",
+      },
+      "parent": Object {
+        "children": Array [],
+        "content": "[{\\"id\\":\\"foo\\",\\"blue\\":true,\\"funny\\":\\"yup\\"},{\\"blue\\":false,\\"funny\\":\\"nope\\"}]",
+        "id": "whatever",
+        "internal": Object {
+          "contentDigest": "whatever",
+          "mediaType": "application/json",
+          "type": "NotFile",
+        },
+        "parent": "SOURCE",
+      },
+    },
+  ],
+  Array [
+    Object {
+      "child": Object {
+        "blue": false,
+        "children": Array [],
+        "funny": "nope",
+        "id": "uuid-from-gatsby",
+        "internal": Object {
+          "contentDigest": "f624311d932d73dcd416d2a8bea2b67d",
+          "type": "NotFileJson",
+        },
+        "parent": "whatever",
+      },
+      "parent": Object {
+        "children": Array [],
+        "content": "[{\\"id\\":\\"foo\\",\\"blue\\":true,\\"funny\\":\\"yup\\"},{\\"blue\\":false,\\"funny\\":\\"nope\\"}]",
+        "id": "whatever",
+        "internal": Object {
+          "contentDigest": "whatever",
+          "mediaType": "application/json",
+          "type": "NotFile",
+        },
+        "parent": "SOURCE",
+      },
+    },
+  ],
+]
+`;