[v2] [cache-dir] Use 404 resources in EnsureResources if the page doesn't exist #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtenfys
changed the title
KyleAMathews
approved these changes
Sep 24, 2018
| window.location.replace(url) | ||
|
|
||
| const url = getRedirectUrl(this.state.location.pathname) | ||
| if (url) window.location.replace(url) |
There was a problem hiding this comment.
Could you use the non-shorthand form?
DSchau
reviewed
Sep 24, 2018
| @@ -16,6 +17,7 @@ class EnsureResources extends React.Component { | |||
| this.state = { | |||
| location: { ...location }, | |||
There was a problem hiding this comment.
Where did we ever end up on this? Is this needed?
There was a problem hiding this comment.
hah, probably not! just don't use git blame - it tells lies!
|
I chatted with @davidbailey00 a little and we (or just him) will iterate on this tomorrow |
vtenfys
changed the title
This was referenced Sep 26, 2018
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Sep 26, 2018
* 'master' of github.com:gatsbyjs/gatsby: feat(cache-dir): Add a button for custom 404s in development (gatsbyjs#8548) fix: add ecosystem team for starters YAML fix: fix displaying and hydrating 404 page in production builds (gatsbyjs#8510) fix: don't expect `application/json` type nodes to be files (gatsbyjs#8544) Delete cds-takeaways.md (gatsbyjs#8552) chore(release): Publish chore: remove npm-run-all dep and update deps in e2e tests (gatsbyjs#8529) [www] Site/Starter Showcase refactor, rinse II (gatsbyjs#8411) Rfc process doc (gatsbyjs#8537) [www] a11y improvements (gatsbyjs#8536) Update the GraphQL stitching blog post & docs (gatsbyjs#8516) fix: change teams to reduce noise for people
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure-resources.jsload-directly-or-404.jsto prevent code reusegetResourcesFromPathnameSyncif the page isn't found, to match behaviour of the async versionFixes #8297