[www] Site/Starter Showcase refactor, rinse II #8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix #7754 - change the Starter Showcase main content headline from "All 60 Starters" to “Gatsby Starters (60)” * DRY — add a couple of shared components: * ResetFilters button * SidebarContainer, SidebarHeader, SidebarBody * ContentHeader with title („Starters“/„Sites“) and count, adjusting title on filter and search * link Creator Showcase detail page GitHub icon
amberleyromo
approved these changes
Sep 21, 2018
|
Yay! Thanks Amberley! |
4 tasks
|
👌 |
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Sep 26, 2018
* 'master' of github.com:gatsbyjs/gatsby: feat(cache-dir): Add a button for custom 404s in development (gatsbyjs#8548) fix: add ecosystem team for starters YAML fix: fix displaying and hydrating 404 page in production builds (gatsbyjs#8510) fix: don't expect `application/json` type nodes to be files (gatsbyjs#8544) Delete cds-takeaways.md (gatsbyjs#8552) chore(release): Publish chore: remove npm-run-all dep and update deps in e2e tests (gatsbyjs#8529) [www] Site/Starter Showcase refactor, rinse II (gatsbyjs#8411) Rfc process doc (gatsbyjs#8537) [www] a11y improvements (gatsbyjs#8536) Update the GraphQL stitching blog post & docs (gatsbyjs#8516) fix: change teams to reduce noise for people
This was referenced Sep 18, 2021
This was referenced Oct 1, 2021
This was referenced Oct 9, 2021
This was referenced Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResetFiltersbuttonSidebarContainer,SidebarHeader,SidebarBodyContentHeaderandContentTitle(„Starters“/„Sites“) and count, adjusting title on filter and searchlink Creator Showcase detail page GitHub iconHere's a screenshot showing the changes for #7754 before/after (also, the Site Showcase headers now behave exactly the same):