Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4 first vis plugin #5

Merged
merged 3 commits into from
Oct 29, 2014
Merged

#4 first vis plugin #5

merged 3 commits into from
Oct 29, 2014

Conversation

wilzbach
Copy link
Contributor

Hi all,

so this is my first, infancy Galaxy visualization plugin as discussed in #4.

  1. I don't know whether it is a good idea to commit the "binary" (compressed,minified) MSA viewer code into this repo. (There exists also a CDN version.)
  2. Is there a better way to load a resource relatively to the plugin folder?
    (this is seems a bit inflexible)
${h.javascript_link( root + 'plugins/visualizations/biojs-msa/static/msa.min.js' )}
  1. Any other suggestions are welcome

@bgruening
Copy link
Member

Seb;

wonderful!
Thanks a lot. Out of curiosity, can your plugin be applied to *.msa files as well? Or the native clustalw format?

Regarding your questions, can you try:

${h.javascript_link( plugin_path + '/static/msa.min.js' )}

I think shipping the binary JS file is ok, because we can't rely on internet connection on every Galaxy host. A few Galaxy instances are not allowed to be part of the Internet (private data issue ...).

@wilzbach
Copy link
Contributor Author

I couldn't find Clustal as input format. So I just picked sequences. Is there a special Clustal format?

plugin_path is great, but unfortunately it is an absolute path :-(

@bgruening
Copy link
Member

@greenify what kind of input formats do you support? I don't understand the problem with the absolute path, what do you need to do, or what is not working?

@wilzbach
Copy link
Contributor Author

what kind of input formats do you support?

Currently Fasta and Clustal

don't understand the problem with the absolute path, what do you need to do, or what is not working?

well /home/... doesn't work in a browser. It thought plugin_path would similar to this:

plugin_path = "/config/plugins/visualizations/biojs-msa/"

@jmchilton
Copy link
Member

Exactly - plugin_path is meant for consumption by Python components - it is a file path not a URL.

@bgruening
Copy link
Member

Here is the clustal datatype. https://github.com/galaxyproject/tools-iuc/blob/master/datatypes/msa/clustal/datatypes_conf.xml But this can be fixed after it is merged.

@carlfeberhard
Copy link

Heya, Seb.

Looks good. The config file is well formed. Might want to close the html tag in the mako template.

For loading scripts, that form is correct for now. Unfortunately, the static directory served by galaxy is set up to be explicit as possible and that makes it a bit long. I'll look into whether there's a way to make relative paths a bit easier.

I really look forward to seeing it in action

@wilzbach
Copy link
Contributor Author

@bgruening Should I use the Clustal datatype even though it is not a standard datatype?

@carlfeberhard any news on the path problem? Can/Should I send a patch to the galaxy mercurial project? Btw it would be super awesome if Galaxy would migrate to Git(hub).

@bgruening
Copy link
Member

@greenify I will add the clustal datatypes later. But can you add a comment which datatypes are supported? Than we can use this as documentation. Preferably as EDAM http://edamontology.org annotation.

@bgruening
Copy link
Member

@carlfeberhard This seems to be fine, right? I will merge this tomorrow if no one complains :)

@wilzbach
Copy link
Contributor Author

@bgruening sorry for being so unresponsive. I am not sure what you expect as EDAM - the EDAM IDs?

ClustalW http://edamontology.org/format_1982
FASTA http://edamontology.org/format_1929

(the MSA only supports FASTA and Clustal at the moment.)

@bgruening
Copy link
Member

Hi @greenify it was just a recommendation for your project and for the documentation. At some point we will have problems to map datatype names. Is it clustal or clustalw or Clustal. If we create such a config file for every biojs visualisation we should agree on some ontology and this is my proposal :)

I will merge this now. Thanks a lot!
Bjoern

bgruening added a commit that referenced this pull request Oct 29, 2014
MSA visualisation plugin based on BioJS.
@bgruening bgruening merged commit f0256c4 into galaxyproject:master Oct 29, 2014
lparsons added a commit to lparsons/tools-iuc that referenced this pull request Jun 27, 2016
fastq-join: now paired collection aware. Limit inputs to fastqsanger …
hexylena pushed a commit that referenced this pull request Aug 7, 2017
hexylena added a commit that referenced this pull request Aug 7, 2017
fix error when using built-in reference genome
bgruening pushed a commit that referenced this pull request Dec 18, 2018
blankenberg pushed a commit to blankenberg/tools-iuc that referenced this pull request Jul 15, 2020
@nsoranzo nsoranzo mentioned this pull request Feb 1, 2021
@thomas-lacroix thomas-lacroix mentioned this pull request Dec 12, 2021
5 tasks
bgruening pushed a commit that referenced this pull request Jan 23, 2024
paulzierep pushed a commit to paulzierep/tools-iuc that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants