-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4 first vis plugin #5
Conversation
Seb; wonderful! Regarding your questions, can you try:
I think shipping the binary JS file is ok, because we can't rely on internet connection on every Galaxy host. A few Galaxy instances are not allowed to be part of the Internet (private data issue ...). |
I couldn't find Clustal as input format. So I just picked
|
@greenify what kind of input formats do you support? I don't understand the problem with the absolute path, what do you need to do, or what is not working? |
Currently Fasta and Clustal
well
|
Exactly - |
Here is the clustal datatype. https://github.com/galaxyproject/tools-iuc/blob/master/datatypes/msa/clustal/datatypes_conf.xml But this can be fixed after it is merged. |
Heya, Seb. Looks good. The config file is well formed. Might want to close the html tag in the mako template. For loading scripts, that form is correct for now. Unfortunately, the static directory served by galaxy is set up to be explicit as possible and that makes it a bit long. I'll look into whether there's a way to make relative paths a bit easier. I really look forward to seeing it in action |
@bgruening Should I use the Clustal datatype even though it is not a standard datatype? @carlfeberhard any news on the path problem? Can/Should I send a patch to the galaxy mercurial project? Btw it would be super awesome if Galaxy would migrate to Git(hub). |
@greenify I will add the clustal datatypes later. But can you add a comment which datatypes are supported? Than we can use this as documentation. Preferably as EDAM http://edamontology.org annotation. |
@carlfeberhard This seems to be fine, right? I will merge this tomorrow if no one complains :) |
@bgruening sorry for being so unresponsive. I am not sure what you expect as EDAM - the EDAM IDs? ClustalW http://edamontology.org/format_1982 (the MSA only supports FASTA and Clustal at the moment.) |
Hi @greenify it was just a recommendation for your project and for the documentation. At some point we will have problems to map datatype names. Is it I will merge this now. Thanks a lot! |
MSA visualisation plugin based on BioJS.
fastq-join: now paired collection aware. Limit inputs to fastqsanger …
fix error when using built-in reference genome
Add .shed.yml
Hi all,
so this is my first, infancy Galaxy visualization plugin as discussed in #4.
(this is seems a bit inflexible)