Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BioJS-MSA doesn't use galaxy prefix #41

Closed
hexylena opened this issue Feb 10, 2015 · 6 comments
Closed

BioJS-MSA doesn't use galaxy prefix #41

hexylena opened this issue Feb 10, 2015 · 6 comments

Comments

@hexylena
Copy link
Member

If galaxy is running with a prefix like /galaxy/, BioJS-MSA is not aware of this.

@saketkc
Copy link

saketkc commented Feb 10, 2015

cc @greenify

@wilzbach
Copy link
Contributor

Last time I asked whether there is a variable or configuration from which the MSA can get the browser path to itself.

I would be happy to change that if Galaxy can give the visualization plugins the absolute url to the them...

@hexylena
Copy link
Member Author

Yes, it can. We've done this with our IPython Viz plugin though I'll have to dig into the code to figure out how we did it. I was seconds away from submitting this issue on biojs2galaxy.

@hexylena
Copy link
Member Author

You've already done it in a couple places, you're just missing some of the others. In galaxy.mako, you have root which will correctly determine the correct root, you just need to use that for url and jsonURL on L43-44

hexylena pushed a commit that referenced this issue Feb 10, 2015
@wilzbach
Copy link
Contributor

Oh sry, I was replying too fast - I was referring to the plugin path which is hard-coded to plugins/visualizations in biojs2galaxy.

thanks to @erasche I updated biojs2galaxy with the correct root url :)

@hexylena
Copy link
Member Author

Oh, yeah, it would be nice if there was a method that'd get the full URL for a viz plugin. Anyway, great, thanks so much for getting this fixed in upstream!

bgruening added a commit that referenced this issue Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants