unicycler: make gfa output really gfa #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test works now. but I'm not sure why the output changed. the text in the old assertion is found in the reverse complement of the sequence in the output. unicycler seems to be able to rotate / reverse complement the sequence if certain genes are found. maybe this does not work anymore, but the required software (BLAST) seems to be working now. |
mvdbeek
approved these changes
Nov 16, 2020
bernt-matthias
force-pushed
the
topic/unicycler-fix
branch
from
c2b6575 to
ef74f59
Compare
seems that the sequence in the gfa is reverse complememted (and maybe also shifted). which is because its circular. so the old assertion did not work.
bernt-matthias
force-pushed
the
topic/unicycler-fix
branch
from
ef74f59 to
4a9aa68
Compare
|
@bgruening fine to go? |
bgruening
approved these changes
Nov 18, 2020
|
Super fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet solving #3203 1st commit just sets the gfa outtype more specific
FOR CONTRIBUTOR: