Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNA STAR allows job submission when required inputs are missing, results in obscure cluster error #1777

Open
jennaj opened this issue Mar 16, 2018 · 0 comments

Comments

@jennaj
Copy link
Member

jennaj commented Mar 16, 2018

The option "Count number of reads per gene" can be set to "Yes" with the option "Gene model (gff3,gtf) file for splice junctions" left without a selected ref anno dataset OR with the option "Reference genome with or without an annotation" set an index without built-in annotation.

"Yes" for the count function is internally dependent on the inclusion of reference annotation from one of these two sources.

When this usage problem occurs, it results in a job failure that is difficult for end users to troubleshoot.

It would be better if the input dependency was trapped and the user was warned at job submission that there are missing required inputs. Tools do this in different ways - but most will highlight the missing input with help text to guide in proper usage.

If we do that, will avoid the job from even being able to be submitted before the inputs are correct and in sync.

Does this PR and others related to the upgraded tool capture this usage issue? Should/could it be added before the MTS is updated? Or possibly at the next update if too late now?
#1726

ping @bgruening

lldelisle added a commit to lldelisle/tools-iuc that referenced this issue Jan 27, 2023
lldelisle added a commit to lldelisle/tools-iuc that referenced this issue Feb 1, 2023
lldelisle added a commit to lldelisle/tools-iuc that referenced this issue Feb 2, 2023
lldelisle added a commit to lldelisle/tools-iuc that referenced this issue Feb 8, 2023
bernt-matthias added a commit that referenced this issue Feb 17, 2023
* update STAR version

* add GeneQuant + outSAMattributes

* remove dup test

* update tool version [no ci]

* lint

* add SAMattributes in macro as suggested by @wm75

* change Cell Ranger to Chromium chemistry

* Update rg_rnaStarSolo.xml

make `--soloCBwhitelist` optional and add limits macro for Smart-Seq

* Update macros.xml

* Update rg_rnaStar.xml

* STAR: allow fasta.gz for reference

plus:

- removed a few redundant name attribs
- increases profile

* use up to date profile

Co-authored-by: M Bernt <[email protected]>

* fix back to line

* increase GenomeGenerateRAM by @nagoue @bgruening @wm75

* fix macro limits + extend to all starSOLO

* use double getVar

* compare params values with command line

* put default value in second getVar

* add colnames to count file

* add outWig to STAR

* add outWig in STARsolo + compress bam

* remove section coverage

* add ftype in test

* fix output matrix for new soloFeatures + add test

* solve #1777

* put quantmode_output in GTFconditional thanks @bernt-matthias

* change default outSAMmapqUnique to 255 like in STAR

* only use soloUMIfiltering when soloUMIdedup is 1MM_CR

* enable to output filtered and raw matrices

* add forgotten requirement

* use @TOOL_VERSION@+galaxy@VERSION_SUFFIX@

* bump version of data_manager

* put back to MAPQ60 with remark

---------

Co-authored-by: Pavankumar Videm <[email protected]>
Co-authored-by: Matthias Bernt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant