Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAR: Add two pass mode #1726

Merged
merged 5 commits into from
Feb 26, 2018
Merged

STAR: Add two pass mode #1726

merged 5 commits into from
Feb 26, 2018

Conversation

TorHou
Copy link
Contributor

@TorHou TorHou commented Feb 16, 2018

This feature is now available in STAR 2.5 and I would really like to use it.

@TorHou TorHou changed the title Add two pass mode STAR: Add two pass mode Feb 16, 2018
@bgruening
Copy link
Member

@TorHou version needs to be bumped and a test would be nice.
@yhoogstrate can you look at this?

@TorHou
Copy link
Contributor Author

TorHou commented Feb 16, 2018

I just realized that all tests that use the star-fusion setting will probably fail now, because I have changed those settings. Twopass mode for star-fusion makes perfect sense however and is the default setting, so I think the test data output should be updated.

@yhoogstrate yhoogstrate self-requested a review February 17, 2018 10:01
@TorHou
Copy link
Contributor Author

TorHou commented Feb 19, 2018

ok. I checked the ouput of the tests, they are all as expected (it's a simple case, as should be). So I think this change is all good.

@yhoogstrate
Copy link
Member

@TorHou Indeed twopass makes also sense for fusion analysis. I don't see any reason why this implementation would fail and given that the test passes it's an OK from my side.

Thanks everyone 👍

@bgruening bgruening merged commit 0e1b5fb into galaxyproject:master Feb 26, 2018
@bgruening
Copy link
Member

Thanks @TorHou and @yhoogstrate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants