solve #1777 #3
Merged
solve #1777 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue was that you could select quantMode != '-' even if you had no gtf which makes an error which is not meaningful. |
5 tasks
|
@bernt-matthias, could you review this? |
Can try :) Could need a bit, sice I give a course these days. Please ping me if I do not respond by next week. |
|
@bernt-matthias If I can take your time to review this PR... |
lldelisle
commented
Feb 8, 2023
lldelisle
pushed a commit
that referenced
this pull request
Jun 6, 2024
clean xml files + add macros + tools name underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a big change as the
quantModeis now inside theGTFconditional.