Expose more tool information / navigability in UI. #17105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jmchilton
force-pushed
the
tool_link
branch
2 times, most recently
from
0a22f23 to
06c48dc
Compare
2 tasks
davelopez
approved these changes
Dec 20, 2023
client/src/components/Markdown/Elements/HistoryDatasetAsTable.vue
Outdated
Show resolved
Hide resolved
davelopez
reviewed
Dec 22, 2023
We had a specific request that job parameter displays that "For: Job parameters as table. The output doesn't show what tool was used, it would be good if it did." I don't want to populate the widget directly with information because it might disrupt the flow of the report but I agree it should be navigable. So I have augmented the widget such that is a title is added - a little info icon will appear in the title span that will show a link to the tool and render the name as it would appear in the tool form. This information should be available in other places for the same reason IMO. So this popover is now used in the job metrics table the same way as well as in the workflow step display Markdown component and in the invocation step display component.
Co-authored-by: David López <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a specific request that job parameter displays that:
I don't want to populate the widget directly with information because it might disrupt the flow of the report but I agree it should be navigable. (See #16994 for a discussion of why I think making report components minimally visibly disruptive is important.)
So I have augmented the widget such that is a title is added - a little info icon will appear in the title span that will show a link to the tool and render the name as it would appear in the tool form. This information should be available in other places for the same reason IMO. So this popover is now used in the job metrics table the same way as well as in the workflow step display Markdown component and in the invocation step display component.
Used in the invocation display:
Used in the workflow display Markdown component
Used in the job parameters display component
This PR builds on the refactoring outlined in #17004 to allow the reuse across these components as well a commit that adds title and footer options to job parameters and job metrics components and #16681 to enable those.
How to test the changes?
(Select all options that apply)
License