-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Expose more tool information / navigability in UI.
We had a specific request that job parameter displays that "For: Job parameters as table. The output doesn't show what tool was used, it would be good if it did." I don't want to populate the widget directly with information because it might disrupt the flow of the report but I agree it should be navigable. So I have augmented the widget such that is a title is added - a little info icon will appear in the title span that will show a link to the tool and render the name as it would appear in the tool form. This information should be available in other places for the same reason IMO. So this popover is now used in the job metrics table the same way as well as in the workflow step display Markdown component and in the invocation step display component.
- Loading branch information
Showing
9 changed files
with
146 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
<script setup lang="ts"> | ||
import { computed, watch } from "vue"; | ||
import { useToolStore } from "@/stores/toolStore"; | ||
const toolStore = useToolStore(); | ||
interface ToolLinkProps { | ||
toolId: string; | ||
toolVersion: string; | ||
} | ||
const props = defineProps<ToolLinkProps>(); | ||
const toolName = computed(() => { | ||
if (props.toolId) { | ||
return toolStore.getToolNameById(props.toolId); | ||
} | ||
return ""; | ||
}); | ||
const toolLink = computed(() => { | ||
return `/root?tool_id=${props.toolId}&tool_version=${props.toolVersion}`; | ||
}); | ||
watch( | ||
props, | ||
() => { | ||
if (props.toolId && !toolStore.getToolForId(props.toolId)) { | ||
toolStore.fetchToolForId(props.toolId); | ||
} | ||
}, | ||
{ immediate: true } | ||
); | ||
</script> | ||
|
||
<template> | ||
<router-link :to="toolLink"> | ||
<b>{{ toolName || toolId }}</b> (Galaxy Version {{ toolVersion }}) | ||
</router-link> | ||
</template> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<script setup lang="ts"> | ||
import ToolLink from "./ToolLink.vue"; | ||
interface ToolLinkPopoverProps { | ||
target: string | Function; | ||
toolId?: string; | ||
toolVersion?: string; | ||
} | ||
withDefaults(defineProps<ToolLinkPopoverProps>(), { | ||
toolId: null, | ||
toolVersion: null, | ||
}); | ||
// default boundary of scrollParent doesn't work well at all in the workflow display list | ||
const boundary = "window"; | ||
</script> | ||
|
||
<template> | ||
<b-popover v-if="toolId" :boundary="boundary" :target="target" triggers="hover"> | ||
Tool: | ||
<ToolLink :tool-id="toolId" :tool-version="toolVersion || 'latest'" /> | ||
</b-popover> | ||
</template> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters