Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Galaxy Markdown directive history_dataset_as_table. #16681

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

jmchilton
Copy link
Member

Adding another Galaxy markdown directive to address some issues outlined in #16556 and some other concerns I've had about displaying data in this format.

Let's do that self documenting thing - the following page content:

Screenshot 2023-09-12 at 5 55 02 PM

generates the following presentations of data:


Screenshot 2023-09-12 at 5 55 53 PM
Screenshot 2023-09-12 at 5 56 26 PM
Screenshot 2023-09-12 at 5 56 45 PM

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. upload a tabular dataset
    2. create a page with the above tags but updated to target your tabular dataset
    3. look at the page

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton force-pushed the history_dataset_as_table branch from d2f1844 to 3bfacb7 Compare October 17, 2023 17:29
@jmchilton jmchilton marked this pull request as ready for review October 20, 2023 13:59
@github-actions github-actions bot added this to the 23.2 milestone Oct 20, 2023
Copy link
Contributor

@assuntad23 assuntad23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice, @jmchilton!

Should you also add this option to the MarkdownToolBox in the jobs section?

@jmchilton jmchilton force-pushed the history_dataset_as_table branch from 3bfacb7 to 175a3e1 Compare November 2, 2023 17:36
@jmchilton
Copy link
Member Author

@assuntad23 - you're correct. I've rebased with those changes but I still think the whole widget needs a lot more help text. I'll try to work on a way to add that outside the context of this PR.

@jmchilton jmchilton force-pushed the history_dataset_as_table branch 2 times, most recently from 79ff6ae to 499fd94 Compare November 6, 2023 16:19
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
@jmchilton jmchilton force-pushed the history_dataset_as_table branch from 499fd94 to 98e5cd0 Compare December 22, 2023 15:45
@jmchilton jmchilton force-pushed the history_dataset_as_table branch from 98e5cd0 to 3f6a0c9 Compare December 22, 2023 22:02
@bgruening bgruening merged commit 3f6a0c9 into galaxyproject:dev Dec 23, 2023
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highlight Included in user-facing release notes at the top kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants