Fixes for job metrics Galaxy markdown component. #16994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So galaxyproject#10121 added back in the title header to the component which is only designed for the dataset details page for an individual dataset - the original implementation striped out the title for that reason. The target might an interesting step of a workflow, a problematic tool, a complex resulting dataset - so trying to come up with a title automically is a little challenging. My thought was therefore to keep the component rendered as simply as possible - since the page or report writer will be the one that has the context for how the component should be titled. It needs a prefix and so the big h2 "Job Metrics" is not useful or wanted I think. galaxyproject#10121 did correctly preserve the removal of the title for the job parameters component - so I think this getting added back in was just an oversight.
mvdbeek
approved these changes
Nov 8, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So #10121 added back in the title header to the component which is only designed for the dataset details page for an individual dataset - the original Markdown implementation striped out the title of that for a good reason.
The target job might an interesting step of a workflow, a problematic tool, an interesting job - so trying to come up with a title atomically is challenging - the context defines why the data is interested. My thought was therefore to keep the component rendered as simply as possible - since the page or report writer will be the one that has the context for how the component should be titled. This component needs a prefix or preamble from the user to be intelligible and so the big h2 "Job Metrics" is not useful or wanted IMO.
#10121 did correctly preserve the removal of the title for the job parameters component - which was always striped out for an identical reason - so I think this getting added back in was just an oversight.
This PR also removes the AWS and Carbon footprint stuff from the component - they take up a ton of real estate. I think the report author should explicitly add those if they are of interest - but that should be a follow up PR.
Before:
After:
How to test the changes?
(Select all options that apply)
License