Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING CHANGE] Replace toggle-privacy key binding with expand-privacy and contract-privacy #1347

Closed
fujiapple852 opened this issue Oct 9, 2024 · 2 comments · Fixed by #1353
Closed

[BREAKING CHANGE] Replace toggle-privacy key binding with expand-privacy and contract-privacy #1347

fujiapple852 opened this issue Oct 9, 2024 · 2 comments · Fixed by #1353
Labels
breaking A breaking change enhancement New feature or request tui
Milestone
0.12.0

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Oct 9, 2024 •
edited
Loading

Add expand-privacy and contract-privacy key bindings which increase and decrease tui-privacy-max-ttl. The value is clamped in the range 0 (i.e. off) and the current maximum ttl of the trace.

Deprecation

This is a breaking change as the existing toggle-privacy key binding has been deprecated.

If used from a configuration file it will result in an error:

$ sudo ./target/debug/trip 1.1.1.1
Error: toggle-privacy in [bindings] section is deprecated, use expand-privacy and contract-privacy instead

If used as a command line parameter (unlikely) it will result in an error:

$ sudo ./target/debug/trip 1.1.1.1 --tui-key-bindings toggle-privacy=o
error: invalid value 'toggle-privacy=o' for '--tui-key-bindings <TUI_KEY_BINDINGS>': toggle-privacy is deprecated, use expand-privacy and contract-privacy instead

For more information, try '--help'.
@fujiapple852 fujiapple852 added enhancement New feature or request triage labels Oct 9, 2024
@fujiapple852 fujiapple852 added this to the 0.12.0 milestone Oct 9, 2024
@fujiapple852 fujiapple852 self-assigned this Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Closed
Closed
@fujiapple852 fujiapple852 changed the title Add tui-privacy config and change default value of tui-privacy-max-ttl [BREAKING CHANGE] Add tui-privacy config and change default value of tui-privacy-max-ttl Oct 14, 2024
@fujiapple852
Copy link
Owner Author

Description of the feature from the 0.9.0 release note here.

fujiapple852 added a commit that referenced this issue Oct 14, 2024
@fujiapple852
feat!: add tui-privacy configuration and change default for `tui-pr…
955bbbb 
…ivacy-max-ttl` (#1347)
fujiapple852 added a commit that referenced this issue Oct 14, 2024
@fujiapple852
doc: update CHANGELOG.md for #1347
8a595d1
fujiapple852 added a commit that referenced this issue Oct 14, 2024
@fujiapple852
doc: add a placeholder section to RELEASES.md for #1347
c550975
fujiapple852 added a commit that referenced this issue Oct 14, 2024
@fujiapple852
doc: updated README.md for #1347
f7c058e
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
feat!: add tui-privacy configuration and change default for `tui-pr…
65c9a86 
…ivacy-max-ttl` (#1347)
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: update CHANGELOG.md for #1347
865a7df
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: add a placeholder section to RELEASES.md for #1347
e867fd9
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
4129aea
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
feat!: add tui-privacy configuration and change default for `tui-pr…
787f0e2 
…ivacy-max-ttl` (#1347)
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: update CHANGELOG.md for #1347
68537cb
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: add a placeholder section to RELEASES.md for #1347
99c7cee
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
35525cd
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: add a section to RELEASES.md for #1347
40f4e21
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
834fb02
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: add a section to RELEASES.md for #1347
11fffe9
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
31a2565
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: add a section to RELEASES.md for #1347
99dfdc4
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
5b7e979
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
fea14ea
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: update CHANGELOG.md for #1347
11b124f
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: add a section to RELEASES.md for #1347
5c5a07f
@fujiapple852 fujiapple852 mentioned this issue Oct 15, 2024
Merged
@fujiapple852 fujiapple852 changed the title [BREAKING CHANGE] Add tui-privacy config and change default value of tui-privacy-max-ttl [BREAKING CHANGE] Add expand-privacy and contract-privacy bindings Oct 15, 2024
@fujiapple852 fujiapple852 changed the title [BREAKING CHANGE] Add expand-privacy and contract-privacy bindings [BREAKING CHANGE] Replace toggle-privacy key binding with expand-privacy and contract-privacy Oct 15, 2024
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
feat(tui): replace toggle-privacy key binding with expand-privacy…
e29fb8d 
… and `contract-privacy` (#1347)
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: updated README.md for #1347
9c90073
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: update CHANGELOG.md for #1347
4f4a31c
fujiapple852 added a commit that referenced this issue Oct 15, 2024
@fujiapple852
doc: update RELEASES.md for #1347
24b134a
@fujiapple852 fujiapple852 added tui breaking A breaking change labels Oct 15, 2024
fujiapple852 added a commit that referenced this issue Oct 16, 2024
@fujiapple852
feat(tui): replace toggle-privacy key binding with expand-privacy…
e56dc23 
… and `contract-privacy` (#1347)
fujiapple852 added a commit that referenced this issue Oct 16, 2024
@fujiapple852
doc: updated README.md for #1347
f254437
fujiapple852 added a commit that referenced this issue Oct 16, 2024
@fujiapple852
doc: update CHANGELOG.md for #1347
00f2d20
fujiapple852 added a commit that referenced this issue Oct 16, 2024
@fujiapple852
doc: update RELEASES.md for #1347
c49544a
@fujiapple852 fujiapple852 removed their assignment Oct 27, 2024
@fujiapple852
Copy link
Owner Author

Related change: #1365

@BrewTestBot BrewTestBot mentioned this issue Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking A breaking change enhancement New feature or request tui
Projects
None yet
Milestone
0.12.0
1 participant
@fujiapple852