Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tui-privacy flag #1346

Closed
wants to merge 4 commits into from
Closed

feat: add tui-privacy flag #1346

wants to merge 4 commits into from

Conversation

fujiapple852
Copy link
Owner

@fujiapple852 fujiapple852 commented Oct 9, 2024 •
edited
Loading

Closes #1347

@fujiapple852 fujiapple852 marked this pull request as draft October 9, 2024 15:59
@fujiapple852 fujiapple852 marked this pull request as ready for review October 14, 2024 13:43
@fujiapple852 fujiapple852 changed the title feat: WIP for tui-privacy flag feat: add tui-privacy flag Oct 14, 2024
c-git
c-git approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@c-git c-git left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm going to install this version and test for a few days but from looking at the code looks ok to merge.

Edit: Tested and everything works as expected.

crates/trippy-tui/src/frontend/tui_app.rs Outdated Show resolved Hide resolved
crates/trippy-tui/src/config/cmd.rs Show resolved Hide resolved
crates/trippy-tui/src/config/cmd.rs Outdated Show resolved Hide resolved
@fujiapple852 fujiapple852 force-pushed the feat-enable-privacy branch 4 times, most recently from 31a2565 to 5b7e979 Compare October 15, 2024 09:58
@fujiapple852
Copy link
Owner Author

Superseded by #1353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-git c-git c-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] Replace toggle-privacy key binding with expand-privacy and contract-privacy
2 participants
@fujiapple852 @c-git