Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expand-privacy and contract-privacy bindings #1353

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Add expand-privacy and contract-privacy bindings #1353

merged 5 commits into from
Oct 16, 2024

Conversation

fujiapple852
Copy link
Owner

@fujiapple852 fujiapple852 commented Oct 15, 2024 •
edited
Loading

Closes #1347

@fujiapple852 fujiapple852 marked this pull request as draft October 15, 2024 13:37
@fujiapple852 fujiapple852 force-pushed the feat-expand-privacy branch 2 times, most recently from b602578 to 6bfe640 Compare October 15, 2024 14:02
@fujiapple852 fujiapple852 changed the title Feat expand privacy Add expand-privacy and contract-privacy bindings Oct 15, 2024
@fujiapple852 fujiapple852 marked this pull request as ready for review October 15, 2024 15:04
@fujiapple852 fujiapple852 mentioned this pull request Oct 15, 2024
Closed
@fujiapple852 fujiapple852 requested a review from c-git October 15, 2024 15:08
c-git
c-git approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@c-git c-git left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Will install and test.

Edit: Tested and seems good to me.

crates/trippy-tui/src/config.rs Show resolved Hide resolved
@fujiapple852 fujiapple852 merged commit c49544a into master Oct 16, 2024
20 checks passed
@fujiapple852 fujiapple852 deleted the feat-expand-privacy branch October 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-git c-git c-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] Replace toggle-privacy key binding with expand-privacy and contract-privacy
2 participants
@fujiapple852 @c-git