Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] Hide source address when tui-privacy-max-ttl is set #1365

Closed
fujiapple852 opened this issue Oct 27, 2024 · 0 comments · Fixed by #1366
Closed

[BREAKING CHANGE] Hide source address when tui-privacy-max-ttl is set #1365

fujiapple852 opened this issue Oct 27, 2024 · 0 comments · Fixed by #1366
Labels
breaking A breaking change enhancement New feature or request tui
Milestone

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Oct 27, 2024

Currently, The tui-privacy-max-ttl flag can be used tp set the maximum ttl of the hop which will be hidden. Setting this to a value of zero (which is also the default) means that no hops will be hidden. Note that ttl are indexed from 1. The source of the trace, as shown in the Target line of the header, is always shown.

This change repurposes the zero value to indicate that the source of the trace, as shown in the Target line of the header, should be hidden. Values of 1.. are interpreted the same way as they are today.

Consequently, the default value has been changed to be none. Therefore, if not explicitly set (via command line argument or in the configuration file), nothing is hidden by default. If explicitly set to zero (the previous default) then the source of the trace will be hidden, and therefore this is a breaking change.

Screenshot 2024-10-27 at 3 07 06 PM
@fujiapple852 fujiapple852 added enhancement New feature or request tui breaking A breaking change labels Oct 27, 2024
@fujiapple852 fujiapple852 self-assigned this Oct 27, 2024
@fujiapple852 fujiapple852 added this to the 0.12.0 milestone Oct 27, 2024
fujiapple852 added a commit that referenced this issue Oct 27, 2024
)

BREAKING CHANGE: the default vaue for `tui-privacy-max-ttl` has changed
from `Some(0)` to `None`.
fujiapple852 added a commit that referenced this issue Oct 27, 2024
)

BREAKING CHANGE: the default vaue for `tui-privacy-max-ttl` has changed
from `Some(0)` to `None`.
fujiapple852 added a commit that referenced this issue Oct 27, 2024
)

BREAKING CHANGE: the default vaue for `tui-privacy-max-ttl` has changed
from `Some(0)` to `None`.
fujiapple852 added a commit that referenced this issue Oct 27, 2024
fujiapple852 added a commit that referenced this issue Oct 27, 2024
)

BREAKING CHANGE: the default vaue for `tui-privacy-max-ttl` has changed
from `Some(0)` to `None`.
fujiapple852 added a commit that referenced this issue Oct 27, 2024
@fujiapple852 fujiapple852 removed their assignment Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change enhancement New feature or request tui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant