[local_auth] Update to pigeon 11 and remove enum wrappers #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
changed the title
stuartmorgan
approved these changes
Aug 30, 2023
| @@ -79,7 +79,7 @@ void main() { | |||
| ]); | |||
| }); | |||
|
|
|||
| test('handles emtpy', () async { | |||
There was a problem hiding this comment.
Are we sure we don't need test coverage of "emtpy" handling?
There was a problem hiding this comment.
I think it's a risk we're going to have to take unfortunately. If we see a flare up of emtpy in the future we can revisit this at that time.
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2023
flutter/packages@64af59e...e7d812c 2023-08-30 [email protected] [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708) 2023-08-30 [email protected] [in_app_purchase] Minor lint cleanup (flutter/packages#4818) 2023-08-30 [email protected] [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809) 2023-08-30 [email protected] [image_picker] Fix link in README file. (flutter/packages#4775) 2023-08-30 [email protected] [web] Use new APIs from `dart:ui_web` (flutter/packages#4168) 2023-08-30 [email protected] Roll Flutter from 6c95737 to 1fe2495 (24 revisions) (flutter/packages#4817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates pigeon version to 11 to remove need for enum wrappers - removes enum wrappers.
Some work toward flutter/flutter#133455