[path_provider] Fix93198: Added getDownloadsDirectory() for Android #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
stuartmorgan
requested changes
Aug 15, 2023
packages/path_provider/path_provider_platform_interface/pubspec.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'main' of https://github.com/flutter/packages into fix4559#
…nto fix4559 pull from origin# Please enter a commit message to explain why this merge is necessary,
|
@stuartmorgan I have made the changes, please have a look 🙂. |
stuartmorgan
requested changes
Aug 18, 2023
packages/path_provider/path_provider_android/test/path_provider_android_test.dart
Show resolved
Hide resolved
camsim99
reviewed
Aug 21, 2023
stuartmorgan
requested changes
Aug 28, 2023
packages/path_provider/path_provider_android/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
packages/path_provider/path_provider_android/test/path_provider_android_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan
requested changes
Aug 28, 2023
stuartmorgan
requested changes
Aug 28, 2023
packages/path_provider/path_provider_android/lib/path_provider_android.dart
Outdated
Show resolved
Hide resolved
packages/path_provider/path_provider_android/test/path_provider_android_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan
approved these changes
Aug 29, 2023
packages/path_provider/path_provider_android/test/path_provider_android_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2023
flutter/packages@64af59e...e7d812c 2023-08-30 [email protected] [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708) 2023-08-30 [email protected] [in_app_purchase] Minor lint cleanup (flutter/packages#4818) 2023-08-30 [email protected] [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809) 2023-08-30 [email protected] [image_picker] Fix link in README file. (flutter/packages#4775) 2023-08-30 [email protected] [web] Use new APIs from `dart:ui_web` (flutter/packages#4168) 2023-08-30 [email protected] Roll Flutter from 6c95737 to 1fe2495 (24 revisions) (flutter/packages#4817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
|
@talhakhan1297 Looks like I have tested in android emulator and I was able to get the path. Is that mentioned by mistake in documentation. 
|
|
@nirmalraj2000 That was an oversight; I've filed flutter/flutter#151823 to track it. In the future, please use the issue tracker to report issues rather than commenting on old PRs. |
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…roid to 2.2.0 (#7181) This PR bumps minimum required path_provider_android to 2.2.0 and updates supported paths matrix since Downloads directory was added to android implementation in version 2.2.0 Was not sure about version bump: when I ran `update-release-info` with `--version=minimal` it didn't update version. But since readme updated, I believe it is worth new version since not everyone reads readme on GitHub. Did not add or change any tests since I think that work was done in #4708 *List which issues are fixed by this PR. You must list at least one issue.* [#151823](flutter/flutter#151823)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Android implementation for the getDownloadsDirectory() function by making getDownloadsDirectory redirect at the Dart level to getExternalStorageDirectories with the downloads directory constant.
List which issues are fixed by this PR. You must list at least one issue.
Fixes #93198
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.