Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update annotations deps to 1.7 #4935

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Update annotations deps to 1.7 #4935

merged 8 commits into from
Oct 24, 2023

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Sep 15, 2023 •
edited
Loading

  • Update annotation dependency
  • Add changelog for update

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gmackall
gmackall reviewed Sep 15, 2023
View reviewed changes
packages/camera/camera_android/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.10.8+9

* Update annotations lib to 1.7.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in other places, I believe this should be "Updates..."

https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks this always bites me. I need to write a pre commit script for this.

@bparrishMines
Copy link
Contributor

Sorry, I just approved the dependabot update for webview_flutter_android: #4891. You can skip that package. Should I leave future updates for this dep to the Android team?

@reidbaker
Copy link
Contributor Author

Sorry, I just approved the dependabot update for webview_flutter_android: #4891. You can skip that package. Should I leave future updates for this dep to the Android team?

No it is totally fine. I noticed that I got 1-2 and decided to just update the whole repo.

@reidbaker
Copy link
Contributor Author

Sorry, I just approved the dependabot update for webview_flutter_android: #4891. You can skip that package. Should I leave future updates for this dep to the Android team?

No it is totally fine. I noticed that I got 1-2 and decided to just update the whole repo.

Actually I got 40% of the way through modifying the update dependencies command to make this super easy in the future but I wanted to get this pr up the same day and reverted those changes locally.

This was referenced Sep 22, 2023
Closed
Closed
@stuartmorgan
Copy link
Contributor

Is this ready to land?

@reidbaker
Copy link
Contributor Author

it was but now has conflicts. Will update and try to land this week.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@auto-submit auto-submit bot merged commit 264b2fc into flutter:main Oct 24, 2023
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
264b2fc Update annotations deps to 1.7 (flutter/packages#4935)
5be1640
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
Roll Packages from 2faf992 to f751ffb (11 revisions) (#137254)
de93f02 
flutter/packages@2faf992...f751ffb

2023-10-25 [email protected] [ci] Enable legacy Android emulator tests (flutter/packages#5190)
2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209)
2023-10-25 [email protected] Replace gems dependency with ruby. (flutter/packages#5219)
2023-10-25 [email protected] Update the ftl hardware version. (flutter/packages#5224)
2023-10-25 [email protected] [ci] Disable Windows Arm64 stable CI (flutter/packages#5217)
2023-10-24 [email protected] [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137)
2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155)
2023-10-24 [email protected] [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105)
2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211)
2023-10-24 [email protected] [ci] Fix legacy Android task names (flutter/packages#5191)
2023-10-24 [email protected] Update annotations deps to 1.7 (flutter/packages#4935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@reidbaker @HugoOlthof
Update annotations deps to 1.7 (flutter#4935)
ad402c4 
- Update annotation dependency
- Add changelog for update
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmackall gmackall gmackall approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera p: file_selector p: flutter_plugin_android_lifecycle p: google_maps_flutter p: image_picker p: in_app_purchase p: path_provider p: url_launcher platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reidbaker @bparrishMines @stuartmorgan @gmackall