[url_launcher] Add an inAppBrowserView mode in implementations
#5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 50efebc.
stuartmorgan
added
the
federated: partial_changes
stuartmorgan
requested review from
cbracken,
gmackall and
ditman
as code owners
|
(This is #5155 with the app-facing package reverted.) |
stuartmorgan
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5211, due to - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 25, 2023
flutter/packages@2faf992...f751ffb 2023-10-25 [email protected] [ci] Enable legacy Android emulator tests (flutter/packages#5190) 2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209) 2023-10-25 [email protected] Replace gems dependency with ruby. (flutter/packages#5219) 2023-10-25 [email protected] Update the ftl hardware version. (flutter/packages#5224) 2023-10-25 [email protected] [ci] Disable Windows Arm64 stable CI (flutter/packages#5217) 2023-10-24 [email protected] [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137) 2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155) 2023-10-24 [email protected] [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105) 2023-10-24 [email protected] [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211) 2023-10-24 [email protected] [ci] Fix legacy Android task names (flutter/packages#5191) 2023-10-24 [email protected] Update annotations deps to 1.7 (flutter/packages#4935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…tter#5211) Implementation package portion of flutter#5155 This adds: - Android support for the new `inAppBrowserView` launch mode which is distinct from `inAppWebView`, so that use cases that require programatic close can specifically request `inAppWebView` instead. - The default for web links is the new `inAppBrowserView` since that gives better results in most cases. - `inAppBrowserView` will still automatically fall back to `inAppBrowserView` in cases where it's not supported. (In the future, we might want to tune that based on feedback. We could instead have three modes: the webview-only mode we now have, the dynamic mode we now have iff the user requested `platformDefault`, and a new Android Custom Tabs-only if it was explicitly requested which would fail if it doesn't work.) - iOS support for treating `inAppBrowserView` as identical to `inAppWebView`, since in practice that's what its `inAppWebView` mode has always been. - Support on all platforms for the new `supportsMode` and `supportsCloseForMode` support query methods. Fixes flutter/flutter#134208
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation package portion of #5155
This adds:
inAppBrowserViewlaunch mode which is distinct frominAppWebView, so that use cases that require programatic close can specifically requestinAppWebViewinstead.inAppBrowserViewsince that gives better results in most cases.inAppBrowserViewwill still automatically fall back toinAppBrowserViewin cases where it's not supported. (In the future, we might want to tune that based on feedback. We could instead have three modes: the webview-only mode we now have, the dynamic mode we now have iff the user requestedplatformDefault, and a new Android Custom Tabs-only if it was explicitly requested which would fail if it doesn't work.)inAppBrowserViewas identical toinAppWebView, since in practice that's what itsinAppWebViewmode has always been.supportsModeandsupportsCloseForModesupport query methods.Fixes flutter/flutter#134208
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).