Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Use new APIs from dart:ui_web #4168

Merged
merged 9 commits into from
Aug 30, 2023
Merged

[web] Use new APIs from dart:ui_web #4168

merged 9 commits into from
Aug 30, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 8, 2023 •
edited by ditman
Loading

The following APIs are now exposed through dart:ui_web which eliminates the need for shims:

  • platformViewRegistry
  • webOnlyAssetManager
  • urlStrategy

Issues

Minimal stable version

THIS PR CANNOT LAND UNTIL THE NEW dart:ui_web APIS MAKE IT INTO A STABLE FLUTTER RELEASE.

@mdebbar mdebbar requested a review from ditman June 8, 2023 18:44
@stuartmorgan
Copy link
Contributor

Update from triage: still waiting on a new stable release.

@ditman
Copy link
Member

ditman commented Aug 1, 2023

@stuartmorgan can we have the waiting for stable update label in this repo as well?

@stuartmorgan
Copy link
Contributor

Done!

@stuartmorgan stuartmorgan added the waiting for stable update Can't be landed until functionality reaches the stable channel label Aug 2, 2023
@stuartmorgan
Copy link
Contributor

@mdebbar Could you add a link to the landed PR (or its commit) that this is waiting for, so that we can easily check its release labels when scanning PRs?

@ditman
Copy link
Member

ditman commented Aug 3, 2023

@stuartmorgan

This is the engine roll into flutter that has the changes that this needs: flutter/flutter@5a7ab5a

@mdebbar
Copy link
Contributor Author

mdebbar commented Aug 7, 2023

Thanks @ditman 🙏

@stuartmorgan
Copy link
Contributor

It looks like 3.13 has this commit, unless I read the commit tags wrong; trying tests again.

@mdebbar
Copy link
Contributor Author

mdebbar commented Aug 29, 2023

@stuartmorgan mind taking a look to make sure I'm doing things right? Specifically:

  • I only updated versions of the *_web packages. Should I also update the version of the root package?
  • I only bumped the flutter sdk version inside *_web packages. Should I do the same in root packages?

@stuartmorgan
Copy link
Contributor

  • I only updated versions of the *_web packages. Should I also update the version of the root package?

No, we only bump constraints in the app-facing package when it's actually necessary (e.g., when exposing a new feature in the app-facing package).

  • I only bumped the flutter sdk version inside *_web packages. Should I do the same in root packages?

No; the resolver will do the right thing. At some future point when the constraint in the app-facing package is updated (for whatever reason) that will have to happen, but CI will flag that because resolving will fail in the legacy tests.

@mdebbar mdebbar requested a review from stuartmorgan August 29, 2023 18:43
@mdebbar mdebbar marked this pull request as ready for review August 29, 2023 18:44
stuartmorgan
stuartmorgan approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am sure not going to miss those shims.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@auto-submit auto-submit bot merged commit bd97d29 into flutter:main Aug 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
bd97d29 [web] Use new APIs from dart:ui_web (flutter/packages#4168)
d72f4e2
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
Roll Packages from 64af59e to e7d812c (6 revisions) (#133765)
28ec737 
flutter/packages@64af59e...e7d812c

2023-08-30 [email protected] [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708)
2023-08-30 [email protected] [in_app_purchase] Minor lint cleanup (flutter/packages#4818)
2023-08-30 [email protected] [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809)
2023-08-30 [email protected] [image_picker] Fix link in README file. (flutter/packages#4775)
2023-08-30 [email protected] [web] Use new APIs from `dart:ui_web` (flutter/packages#4168)
2023-08-30 [email protected] Roll Flutter from 6c95737 to 1fe2495 (24 revisions) (flutter/packages#4817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ditman ditman mentioned this pull request Sep 5, 2023
Closed
2 tasks
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
Merged
11 tasks
@mdebbar mdebbar deleted the dart_ui_web branch April 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo left review comments

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera p: google_maps_flutter p: google_sign_in p: pointer_interceptor p: url_launcher p: video_player p: webview_flutter platform-web waiting for stable update Can't be landed until functionality reaches the stable channel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup dart:ui shim for web-only APIs in web plugins.
4 participants
@mdebbar @stuartmorgan @ditman @kevmoo