Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell] Update stale comments after multi-view #39298

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[Shell] Update stale comments after multi-view #39298

merged 1 commit into from
Jan 31, 2023

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jan 31, 2023 •
edited
Loading

Follow-up to #38453, part of flutter/flutter#112204

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma marked this pull request as ready for review January 31, 2023 22:43
goderbauer
goderbauer approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dkwingsmt
dkwingsmt approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023
@auto-submit auto-submit bot merged commit d13ad26 into flutter:main Jan 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
d13ad269f [Shell] Update stale comments after multi-view (flutter/eng…
6c86550 
…ine#39298)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
d13ad269f [Shell] Update stale comments after multi-view (flutter/eng…
040e4bc 
…ine#39298)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (#…
dc86565 
…119670)

* 6678d9cc6 clipPath to use fillType param (flutter/engine#38956)

* 5c83e6eac Remove uses of `--full-dart-sdk` from the engine_v2 builders. (flutter/engine#39297)

* d13ad269f [Shell] Update stale comments after multi-view (flutter/engine#39298)

* 521b97544 Roll Fuchsia Mac SDK from IdMSzll1VeWJMV6v8... to Clk4li1185E2JoIkU... (flutter/engine#39300)
@loic-sharma loic-sharma deleted the shell-multiview-comments branch February 1, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@yaakovschectman yaakovschectman Awaiting requested review from yaakovschectman

@cbracken cbracken Awaiting requested review from cbracken

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic-sharma @goderbauer @dkwingsmt