Remove uses of --full-dart-sdk from the engine_v2 builders.
#39297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
Also, do not produce host-specific web_sdk artifacts in the builders.
eyebrowsoffire
force-pushed
the
engine_v2_updates
branch
from
de9331a to
1dacde2
Compare
godofredoc
reviewed
Jan 31, 2023
| @@ -78,7 +78,6 @@ | |||
| "out/host_debug/zip_archives/linux-x64/font-subset.zip", | |||
| "out/host_debug/zip_archives/flutter_patched_sdk.zip", | |||
| "out/host_debug/zip_archives/dart-sdk-linux-x64.zip", | |||
| "out/host_debug/zip_archives/flutter-web-sdk-linux-x64.zip", | |||
There was a problem hiding this comment.
Does this mean we don't need this artifact anymore?
There was a problem hiding this comment.
That's correct. The flutter tool no longer uses any of the host specific flutter-web-sdk artifacts (i.e. flutter-web-sdk-{platform-name}.zip). It now just uses flutter-web-sdk.zip which is host-agnostic, and that is produced by the linux_host_engine builder.
There was a problem hiding this comment.
Thanks for the explanation. LGTM.
godofredoc
approved these changes
Jan 31, 2023
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 1, 2023
…119670) * 6678d9cc6 clipPath to use fillType param (flutter/engine#38956) * 5c83e6eac Remove uses of `--full-dart-sdk` from the engine_v2 builders. (flutter/engine#39297) * d13ad269f [Shell] Update stale comments after multi-view (flutter/engine#39298) * 521b97544 Roll Fuchsia Mac SDK from IdMSzll1VeWJMV6v8... to Clk4li1185E2JoIkU... (flutter/engine#39300)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some of the engine_v2 builders to get them away from the old "host build to make the web sdk" pattern.