Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell] Update stale comments after multi-view #39298

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[Shell] Update stale comments after multi-view #39298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions runtime/platform_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,18 @@
namespace flutter {

//------------------------------------------------------------------------------
/// The struct of platform-specific data used for initializing ui.Window.
/// The struct of platform-specific data used for initializing
/// ui.PlatformDispatcher.
///
/// framework may request data from ui.Window before platform is properly
/// configured. Engine this struct to set the desired default value for
/// ui.Window when creating Shell before platform is ready to send the real
/// The framework may request data from ui.PlatformDispatcher before the
/// platform is properly configured. When creating the Shell, the engine sets
/// this struct to default values until the platform is ready to send the real
/// data.
///
/// See also:
///
/// * flutter::Shell::Create, which takes a platform_data to initialize the
/// ui.Window attached to it.
/// ui.PlatformDispatcher attached to it.
struct PlatformData {
PlatformData();

Expand Down
2 changes: 1 addition & 1 deletion shell/common/shell.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ class Shell final : public PlatformView::Delegate,
std::atomic<bool> needs_report_timings_{false};

// Whether there's a task scheduled to report the timings to Dart through
// ui.Window.onReportTimings.
// ui.PlatformDispatcher.onReportTimings.
bool frame_timings_report_scheduled_ = false;

// Vector of FrameTiming::kCount * n timestamps for n frames whose timings
Expand Down