Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipPath to use fillType param #38956

Merged
merged 1 commit into from
Jan 31, 2023
Merged

clipPath to use fillType param #38956

merged 1 commit into from
Jan 31, 2023

Conversation

alanwutang11
Copy link
Contributor

@alanwutang11 alanwutang11 commented Jan 17, 2023 •
edited
Loading

When using DOM rendering with HTML renderer, specifying path.fillType to evenOdd had no effect.

Fixed so that we account for the fillType param for a path.

fixes: flutter/flutter#81637

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jan 17, 2023
@alanwutang11 alanwutang11 marked this pull request as ready for review January 18, 2023 00:08
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #38956 at sha 4077e87

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2023

auto label is removed for flutter/engine, pr: 38956, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 30, 2023

auto label is removed for flutter/engine, pr: 38956, due to Validations Fail.

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2023
@auto-submit auto-submit bot merged commit 6678d9c into flutter:main Jan 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
6678d9cc6 clipPath to use fillType param (flutter/engine#38956)
066a315
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
6678d9cc6 clipPath to use fillType param (flutter/engine#38956)
464b1d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
6678d9cc6 clipPath to use fillType param (flutter/engine#38956)
fb0a4f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
6678d9cc6 clipPath to use fillType param (flutter/engine#38956)
a26ade6
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (#…
dc86565 
…119670)

* 6678d9cc6 clipPath to use fillType param (flutter/engine#38956)

* 5c83e6eac Remove uses of `--full-dart-sdk` from the engine_v2 builders. (flutter/engine#39297)

* d13ad269f [Shell] Update stale comments after multi-view (flutter/engine#39298)

* 521b97544 Roll Fuchsia Mac SDK from IdMSzll1VeWJMV6v8... to Clk4li1185E2JoIkU... (flutter/engine#39300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClipPath not working properly with web html renderer
3 participants
@alanwutang11 @yjbanov @mdebbar