Network update #953
Merged
Network update #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eugenevinitsky
commented
May 27, 2020
eugenevinitsky
commented
- put in correct version of i210
- put in correct version of straight road
- better logging in train.py
- curricula in i210 env
Added code to output json. Added code to resolve macOS matplotlib imp…
* deleting unworking params from SumoChangeLaneParams * deleted unworking params, sublane working in highway : * moved imports inside functions * Apply suggestions from code review * bug fixes * bug fix Co-authored-by: Aboudy Kreidieh <[email protected]>
…es are immediately put back
* added bando model * added ghost edge to the highway network * added highway-single example * bug fixes * more tests
* Add the appropriate reward to the grid benchmark back * Put the bottleneck in a congested regime * Bump bottleneck inflows to put it in the congested regime
* added function to kernel/vehicle to get number of not departed vehiles * fixed over indentation of the docstring * indentation edit * pep8 Co-authored-by: AboudyKreidieh <[email protected]>
* changed _departed_ids, and _arrived_ids in the update function * fixed bug in get_departed_ids and get_arrived_ids
Updated ray_autoscale and requirements.txt
eugenevinitsky
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
kjang96
requested changes
May 28, 2020
flow/controllers/base_controller.py
Outdated
Comment on lines
117
to
118
| else: | ||
| accel = min(max(accel, -self.max_deaccel), self.max_accel) |
There was a problem hiding this comment.
this is already added into the Flow failsafes, so if you want it, use fail_safe='feasible_accel'
kjang96
requested changes
May 28, 2020
flow/envs/multiagent/__init__.py
Outdated
| @@ -10,7 +10,8 @@ | |||
| from flow.envs.multiagent.traffic_light_grid import MultiTrafficLightGridPOEnv | |||
| from flow.envs.multiagent.highway import MultiAgentHighwayPOEnv | |||
| from flow.envs.multiagent.merge import MultiAgentMergePOEnv | |||
| from flow.envs.multiagent.i210 import I210MultiEnv, MultiStraightRoad | |||
| from flow.envs.multiagent.i210 import I210MultiEnv, MultiStraightRoad, I210MADDPGMultiEnv, MultiStraightRoadMADDPG | |||
There was a problem hiding this comment.
I210MADDPGMultiEnv import doesn't work. Try running python train.py multiagent_i210 test to verify
| from ray.rllib.evaluation.postprocessing import compute_advantages, \ | ||
| Postprocessing | ||
| from ray.rllib.policy.sample_batch import SampleBatch | ||
| from ray.rllib.policy.tf_policy import LearningRateSchedule, \ |
There was a problem hiding this comment.
the ACTION_LOGP import fails for me
kjang96
requested changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.